You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Brandon Li (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 17:52:23 UTC
[jira] [Created] (HDFS-3127) failure in recovering removed storage
directories should not stop checkpoint process
failure in recovering removed storage directories should not stop checkpoint process
------------------------------------------------------------------------------------
Key: HDFS-3127
URL: https://issues.apache.org/jira/browse/HDFS-3127
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 1.1.0
Reporter: Brandon Li
Assignee: Brandon Li
When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236270#comment-13236270 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3127:
----------------------------------------------
Oops, sorry Aaron. I did not see your new comment. I started committing the patch right after I posted the test-patch result. I will file a JIRA to address your comments.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Fix For: 1.0.2
>
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236272#comment-13236272 ]
Aaron T. Myers commented on HDFS-3127:
--------------------------------------
Haha - looks like our comments raced with each other. :)
Thanks for filing the JIRA to address the comments.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Fix For: 1.0.2
>
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Brandon Li (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236088#comment-13236088 ]
Brandon Li commented on HDFS-3127:
----------------------------------
I ran test-core and it passed.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Jitendra Nath Pandey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235883#comment-13235883 ]
Jitendra Nath Pandey commented on HDFS-3127:
--------------------------------------------
I should have mentioned earlier, please add a test for this.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236258#comment-13236258 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3127:
----------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
{noformat}
The findbugs warnings are not related to the patch. The result is the same for an empty patch.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3127) failure in recovering removed storage
directories should not stop checkpoint process
Posted by "Matt Foley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-3127:
-----------------------------
Fix Version/s: (was: 1.0.2)
1.0.3
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Fix For: 1.0.3
>
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3127) failure in recovering removed storage
directories should not stop checkpoint process
Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HDFS-3127:
-----------------------------
Attachment: HDFS-3127.branch-1.patch
More test case is added in the new patch.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236274#comment-13236274 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3127:
----------------------------------------------
Appreciate your understanding! Filed HDFS-3131.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Fix For: 1.0.2
>
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Jitendra Nath Pandey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236189#comment-13236189 ]
Jitendra Nath Pandey commented on HDFS-3127:
--------------------------------------------
+1
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Brandon Li (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236012#comment-13236012 ]
Brandon Li commented on HDFS-3127:
----------------------------------
Trunk doesn't have this problem.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-3127) failure in recovering removed storage
directories should not stop checkpoint process
Posted by "Tsz Wo (Nicholas), SZE (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HDFS-3127.
------------------------------------------
Resolution: Fixed
Fix Version/s: 1.0.2
Hadoop Flags: Reviewed
I have committed this. Thanks Brandon!
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Fix For: 1.0.2
>
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3127) failure in recovering removed storage
directories should not stop checkpoint process
Posted by "Brandon Li (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HDFS-3127:
-----------------------------
Attachment: HDFS-3127.branch-1.patch
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236003#comment-13236003 ]
Aaron T. Myers commented on HDFS-3127:
--------------------------------------
Does this change not also need to be made on trunk?
Also, please run the full HDFS test suite before committing this.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236271#comment-13236271 ]
Aaron T. Myers commented on HDFS-3127:
--------------------------------------
Nicholas, why weren't my comments addressed before commit?
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Fix For: 1.0.2
>
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236259#comment-13236259 ]
Aaron T. Myers commented on HDFS-3127:
--------------------------------------
Patch largely looks good, Brandon. A few comments:
# removeStorageAccess, restoreAccess, and numStorageDirs can all be made private
# numStorageDirs can be made static
# Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
# Please put the contents of the test in a try/finally, with the calls to shutdown the cluster and the 2NN in the finally block.
# Some lines are over 80 chars.
# No need for the numDatanodes variable - it's only used in one place.
# Instead of "xwr" use "rwx", which I think is a more common way of describing permissions.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3127) failure in recovering removed
storage directories should not stop checkpoint process
Posted by "Jitendra Nath Pandey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235878#comment-13235878 ]
Jitendra Nath Pandey commented on HDFS-3127:
--------------------------------------------
+1, looks good to me.
> failure in recovering removed storage directories should not stop checkpoint process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy directories. Any exceptions from recovering the removed directories should not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira