You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/22 13:43:57 UTC
[GitHub] [airflow] derrickqin opened a new pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
derrickqin opened a new pull request #10475:
URL: https://github.com/apache/airflow/pull/10475
Add support for creating multiple replicated clusters in Bigtable hook and operator
closes: #10474
Changes:
1. Added a new parameter called **replica_clusters** to allow creating multiple Bigtable replicated clusters
2. Made existing **replica_cluster_id** and **replica_cluster_zone** deprecated, but still working
3. Added unit tests for both hook and operator
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #10475:
URL: https://github.com/apache/airflow/pull/10475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10475:
URL: https://github.com/apache/airflow/pull/10475#issuecomment-678643024
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] derrickqin commented on pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
derrickqin commented on pull request #10475:
URL: https://github.com/apache/airflow/pull/10475#issuecomment-678643751
@turbaszek @ryanyuan PTAL. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10475:
URL: https://github.com/apache/airflow/pull/10475#issuecomment-678743478
@derrickqin would you mind rebasing onto current master? There seems to be an issue with CI :<
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] derrickqin commented on pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
derrickqin commented on pull request #10475:
URL: https://github.com/apache/airflow/pull/10475#issuecomment-678714980
@turbaszek could you please merge it? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10475:
URL: https://github.com/apache/airflow/pull/10475#issuecomment-679025665
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10475:
URL: https://github.com/apache/airflow/pull/10475#issuecomment-678829355
Quarantined builds fail from time to time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] derrickqin commented on pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
derrickqin commented on pull request #10475:
URL: https://github.com/apache/airflow/pull/10475#issuecomment-678770799
@turbaszek could you please have another look? CI build failed on Quarantined tests, don't think it is related to my change...
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10475: Add support for creating multiple replicated clusters in Bigtable hook and operator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10475:
URL: https://github.com/apache/airflow/pull/10475#issuecomment-679300241
Hello @derrickqin -> I believe merging that change broke our master. It's most likely not your fault, it's either some coincidence/race between your changes/master changes or a problem I described in #10471.
I am going to investigate it, but it would help tremendously if you rebase your local branch to latest master (after we merge #10522), and then re-submit the PR again - so that we could see what was the root cause of the problem ?
That would be super helpful if you do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org