You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/02/13 18:29:59 UTC
[GitHub] incubator-brooklyn pull request: Strip "Expect: 100-Continue" head...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/513
Strip "Expect: 100-Continue" header in Jclouds object store
The 100 Continue response causes the Java 7,8 http client to misbehave,
more so when used in SSL mode.
Sockets closed by GC break the internal bookkeeping
of HttpUrlConnection, leading to invalid handling of the "HTTP/1.1 100 Continue"
response. Coupled with a bug when using SSL sockets reads will block
indefinitely even though a read timeout is explicitly set.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn strip-expect-100
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #513
----
commit 176899056f4a599686749724cc207c895aab8539
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-02-13T15:10:30Z
Strip "Expect: 100-Continue" header in Jclouds object store
The 100 Continue response causes the Java 7,8 http client to misbehave,
more so when used in SSL mode.
Sockets closed by GC break the internal bookkeeping
of HttpUrlConnection, leading to invalid handling of the "HTTP/1.1 100 Continue"
response. Coupled with a bug when using SSL sockets reads will block
indefinitely even though a read timeout is explicitly set.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Strip "Expect: 100-Continue" head...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/513#issuecomment-74295029
This was a terrible bug, or rather pair of bugs, incredibly hard to track down, particularly since you couldn't get the softlayer SSL keys to see the https wire traffic.
One doesn't expect Java 8 HTTP code to be buggy!
Tremendous work @neykov .
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Strip "Expect: 100-Continue" head...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---