You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/23 03:16:49 UTC
[GitHub] [skywalking] aoxls opened a new issue #7161: A bug in client-js
aoxls opened a new issue #7161:
URL: https://github.com/apache/skywalking/issues/7161
[https://github.com/apache/skywalking-client-js/blob/master/src/trace/interceptors/fetch.ts#L82](https://github.com/apache/skywalking-client-js/blob/master/src/trace/interceptors/fetch.ts#L82)
if `args[1]` is an object without property `headers`, it will throw an exception here.
suggestion：
```js
if (!args[1]) {
args[1] = {};
}
if (!args[1].headers) {
args[1].headers = {};
}
args[1].headers['sw8'] = values;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Fine0830 closed issue #7161: [Client JS] headers could be null
Posted by GitBox <gi...@apache.org>.
Fine0830 closed issue #7161:
URL: https://github.com/apache/skywalking/issues/7161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7161: A bug in client-js
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7161:
URL: https://github.com/apache/skywalking/issues/7161#issuecomment-866496905
@aoxls If you want a bug to fix, you could submit a pull request directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] aoxls commented on issue #7161: [Client JS] headers could be null
Posted by GitBox <gi...@apache.org>.
aoxls commented on issue #7161:
URL: https://github.com/apache/skywalking/issues/7161#issuecomment-866569185
OK, I have submitted a pull request already, please review it.
https://github.com/apache/skywalking-client-js/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org