You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2019/06/15 16:22:44 UTC

[trafficserver] 14/23: Step 14: Removes numberOfVersions() and getCurrentVersion()

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit 169200088a7faacb8b9562a1b2c0384c4ea40272
Author: Leif Hedstrom <zw...@apache.org>
AuthorDate: Fri May 24 16:53:18 2019 -0600

    Step 14: Removes numberOfVersions() and getCurrentVersion()
---
 mgmt/Rollback.h | 30 ------------------------------
 1 file changed, 30 deletions(-)

diff --git a/mgmt/Rollback.h b/mgmt/Rollback.h
index 8b8d5a5..e112047 100644
--- a/mgmt/Rollback.h
+++ b/mgmt/Rollback.h
@@ -54,23 +54,6 @@ struct versionInfo {
 //
 //  public functions
 //
-//  _ml functions assume the callee is handling locking issues
-//    via acquireLock() and releaseLock().  The non _ml
-//    simply grab the lock, call the corresponding _ml function,
-//    and then release the lock
-//
-//  getVersion(version_t version, TextBuffer** buffer, version_t) -
-//    creates a new TextBuffer that contains the contents of the specified
-//    version.  CALLEE MUST DELETE the buffer
-//
-//  getCurrentVersion() - returns the current version number.  Unless the
-//    callee was acquired the fileAccessLock, the return value only represents
-//    a snap shot in time
-//
-//  numberOfVersions() - returns the number of versions in the config dir.
-//    Unless the callee was acquired the fileAccessLock, the return value
-//    only represents a snap shot in time
-//
 //  checkForUserUpdate() - compares the last known modification time
 //    of the active version of the file with that files current modification
 //    time.  Returns true if the file has been changed manually or false
@@ -115,19 +98,6 @@ public:
   bool checkForUserUpdate();
   bool setLastModifiedTime();
 
-  // Lock not necessary since these are only valid for a
-  //  snap shot in time
-  version_t
-  getCurrentVersion() const
-  {
-    return currentVersion;
-  };
-  int
-  numberOfVersions() const
-  {
-    return numVersions;
-  }
-
   // Not file based so no lock necessary
   const char *
   getBaseName() const