You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2023/01/15 14:34:35 UTC
[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4170: [Arrow] Fix possible `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
bowenliang123 opened a new pull request, #4170:
URL: https://github.com/apache/kyuubi/pull/4170
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix possible `fallthrough` cases:
- in DECIMAL_TYPE case of `ArrowUtils#toArrowType`
- in "arrow" case of `KyuubiStatement#executeAsync`
The cases above are discovered from warning from javac output, and these warnings will be eliminated:
```
/home/runner/work/kyuubi/kyuubi/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java:283: warning: [fallthrough] possible fall-through into case
default:
^
/home/runner/work/kyuubi/kyuubi/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/arrow/ArrowUtils.java:83: warning: [fallthrough] possible fall-through into case
case DATE_TYPE:
^
```
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4170: [Arrow] Fix possible `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4170:
URL: https://github.com/apache/kyuubi/pull/4170#issuecomment-1383166775
Discovered this minor bug when working on https://github.com/apache/kyuubi/pull/4166.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you commented on pull request #4170: [Arrow] Fix `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #4170:
URL: https://github.com/apache/kyuubi/pull/4170#issuecomment-1383395866
good catch !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4170: [Arrow] Fix possible `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4170:
URL: https://github.com/apache/kyuubi/pull/4170#issuecomment-1383167427
cc @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4170: [Arrow] Fix possible `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4170:
URL: https://github.com/apache/kyuubi/pull/4170#issuecomment-1383167121
cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you closed pull request #4170: [Arrow] Fix `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #4170: [Arrow] Fix `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
URL: https://github.com/apache/kyuubi/pull/4170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4170: [Arrow] Fix `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4170:
URL: https://github.com/apache/kyuubi/pull/4170#issuecomment-1383398105
> good catch !
Thx. Warning messages are worth a closer look to seek possible bugs.
And that's why I am cleaning up unhelpful messages in https://github.com/apache/kyuubi/pull/4166.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you commented on pull request #4170: [Arrow] Fix `fallthrough` cases in type conversion and resultset handling in kyuubi-hive-jdbc
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #4170:
URL: https://github.com/apache/kyuubi/pull/4170#issuecomment-1383395941
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org