You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2023/02/24 09:04:11 UTC

[GitHub] [pulsar] nodece opened a new pull request, #19632: [fix][ci] Fix broken CI

nodece opened a new pull request, #19632:
URL: https://github.com/apache/pulsar/pull/19632

   ### Motivation
   
   Error 1:
   ```
   Error:  Failures: 
     Error:  org.apache.pulsar.broker.service.BrokerServiceTest.testGetTopic(org.apache.pulsar.broker.service.BrokerServiceTest)
     [INFO]   Run 1: PASS
     Error:    Run 2: BrokerServiceTest.testGetTopic:1492 expected [0] but found [1]
     [INFO] 
   ```
   
   Error 2:
   ```
   leveldb-0.10.jar unaccounted for in lib/presto/LICENSE
   leveldb-api-0.10.jar unaccounted for in lib/presto/LICENSE
   leveldb-0.[12](https://github.com/apache/pulsar/actions/runs/4239032335/jobs/7399965467#step:11:13).jar mentioned in lib/presto/LICENSE, but not bundled
   leveldb-api-0.12.jar mentioned in lib/presto/LICENSE, but not bundled
   ```
   
   ### Modifications
   
   - Fix test
   - Fix presto license
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #19632: [fix][ci][branch-2.11] Fix broken CI

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #19632:
URL: https://github.com/apache/pulsar/pull/19632#issuecomment-1443246575

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #19632: [fix][ci][branch-2.11] Fix broken CI

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #19632:
URL: https://github.com/apache/pulsar/pull/19632#issuecomment-1449476012

   ping @Technoboy-, the CI has been passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- commented on pull request #19632: [fix][ci][branch-2.11] Fix broken CI

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #19632:
URL: https://github.com/apache/pulsar/pull/19632#issuecomment-1444972502

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- merged pull request #19632: [fix][ci][branch-2.11] Fix broken CI

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #19632:
URL: https://github.com/apache/pulsar/pull/19632


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #19632: [fix][ci][branch-2.11] Fix broken CI

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #19632:
URL: https://github.com/apache/pulsar/pull/19632#discussion_r1121378661


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -956,13 +956,18 @@ public CompletableFuture<Optional<Topic>> getTopic(final String topic, boolean c
 
     public CompletableFuture<Optional<Topic>> getTopic(final String topic, boolean createIfMissing,
                                                        Map<String, String> properties) {
+        return getTopic(TopicName.get(topic), createIfMissing, properties);
+    }
+
+    public CompletableFuture<Optional<Topic>> getTopic(final TopicName topicName, boolean createIfMissing,

Review Comment:
   @nodece may you talk a bit detail how this change fixes the issue? And if a similar issue is in the master branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on a diff in pull request #19632: [fix][ci][branch-2.11] Fix broken CI

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on code in PR #19632:
URL: https://github.com/apache/pulsar/pull/19632#discussion_r1121399630


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -956,13 +956,18 @@ public CompletableFuture<Optional<Topic>> getTopic(final String topic, boolean c
 
     public CompletableFuture<Optional<Topic>> getTopic(final String topic, boolean createIfMissing,
                                                        Map<String, String> properties) {
+        return getTopic(TopicName.get(topic), createIfMissing, properties);
+    }
+
+    public CompletableFuture<Optional<Topic>> getTopic(final TopicName topicName, boolean createIfMissing,

Review Comment:
   See https://github.com/apache/pulsar/pull/17416



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org