You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/02 03:02:00 UTC

[GitHub] [incubator-apisix] wingsjj opened a new pull request #1793: feature: using GitHub action for CI

wingsjj opened a new pull request #1793:
URL: https://github.com/apache/incubator-apisix/pull/1793


   # Summary
   
   using GitHub action for CI
   
   ### Full changelog
   
   feature: using GitHub action for CI
   update:  .travis/linux_openresty_runner.sh
   update: .travis/linux_tengine_runner.sh
   update:  t/node/remote-addr-ipv6.t
   
   ### Issues resolved
   
   Fix #1789
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on a change in pull request #1793: feature: using GitHub action for CI

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1793:
URL: https://github.com/apache/incubator-apisix/pull/1793#discussion_r448724281



##########
File path: .github/workflows/build.yml
##########
@@ -0,0 +1,63 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master

Review comment:
       we need to run the GitHub action for every PR. blow is better.
   
   ```yaml
   on:
     push:
       branches: [ master ]
     pull_request:
       branches: [ master ]
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] moonming merged pull request #1793: feature: using GitHub action for CI

Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1793:
URL: https://github.com/apache/incubator-apisix/pull/1793


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on pull request #1793: feature: using GitHub action for CI

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1793:
URL: https://github.com/apache/incubator-apisix/pull/1793#issuecomment-655912271


   @wingsjj many thx, merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org