You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "po-168 (via GitHub)" <gi...@apache.org> on 2024/11/01 08:27:30 UTC
[PR] [Improve]Test case optimization(#5743) [shenyu]
po-168 opened a new pull request, #5744:
URL: https://github.com/apache/shenyu/pull/5744
<!-- Describe your PR here; e.g. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve]Test case optimization(#5743) [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #5744:
URL: https://github.com/apache/shenyu/pull/5744#issuecomment-2452813571
> @Aias00 Please review code PR
hi, at least u should make the ci success
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve]Test case optimization(#5743) [shenyu]
Posted by "po-168 (via GitHub)" <gi...@apache.org>.
po-168 closed pull request #5744: [Improve]Test case optimization(#5743)
URL: https://github.com/apache/shenyu/pull/5744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve]Test case optimization(#5743) [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #5744:
URL: https://github.com/apache/shenyu/pull/5744#issuecomment-2452844290
> > > @Aias00 Please review code PR
> >
> >
> > hi, at least u should make the ci success
>
> Local verification is successful. I don’t know why. Can you give me some help? I want to solve this PR as soon as possible.
hi,the error shows ur checkstyle not passed,when u coding local,u should make mvn checkstyle passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve]Test case optimization(#5743) [shenyu]
Posted by "po-168 (via GitHub)" <gi...@apache.org>.
po-168 commented on PR #5744:
URL: https://github.com/apache/shenyu/pull/5744#issuecomment-2452947919
> > > > @Aias00 Please review code PR
> > >
> > >
> > > hi, at least u should make the ci success
> >
> >
> > Local verification is successful. I don’t know why. Can you give me some help? I want to solve this PR as soon as possible.
>
> hi,the error shows ur checkstyle not passed,when u coding local,u should make mvn checkstyle passed
Hi,TKS, According to your instructions, I have resolved the issue, but I have created a new PR(#5745) that I have already closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve]Test case optimization(#5743) [shenyu]
Posted by "po-168 (via GitHub)" <gi...@apache.org>.
po-168 commented on PR #5744:
URL: https://github.com/apache/shenyu/pull/5744#issuecomment-2451859940
@Aias00 Please review code PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve]Test case optimization(#5743) [shenyu]
Posted by "po-168 (via GitHub)" <gi...@apache.org>.
po-168 commented on PR #5744:
URL: https://github.com/apache/shenyu/pull/5744#issuecomment-2452816165
> > @Aias00 Please review code PR
>
> hi, at least u should make the ci success
Local verification is successful. I don’t know why. Can you give me some help? I want to solve this PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org