You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2013/09/03 14:24:51 UTC

[jira] [Commented] (LUCENE-5199) Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat in user per-field

    [ https://issues.apache.org/jira/browse/LUCENE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756555#comment-13756555 ] 

Shai Erera commented on LUCENE-5199:
------------------------------------

Core and Facet tests pass (only users of this API). I think it's ready to commit. We can add more formats as Jenkins hunts them down (if there are any).
                
> Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat in user per-field
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5199
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5199
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUENE-5199.patch
>
>
> On LUCENE-5178 Han reported the following test failure:
> {noformat}
> [junit4] FAILURE 0.27s | TestRangeAccumulator.testMissingValues <<<
>    [junit4]    > Throwable #1: org.junit.ComparisonFailure: expected:<...(0)
>    [junit4]    >   less than 10 ([8)
>    [junit4]    >   less than or equal to 10 (]8)
>    [junit4]    >   over 90 (8)
>    [junit4]    >   9...> but was:<...(0)
>    [junit4]    >   less than 10 ([28)
>    [junit4]    >   less than or equal to 10 (2]8)
>    [junit4]    >   over 90 (8)
>    [junit4]    >   9...>
>    [junit4]    > 	at __randomizedtesting.SeedInfo.seed([815B6AA86D05329C:EBC638EE498F066D]:0)
>    [junit4]    > 	at org.apache.lucene.facet.range.TestRangeAccumulator.testMissingValues(TestRangeAccumulator.java:670)
>    [junit4]    > 	at java.lang.Thread.run(Thread.java:722)
> {noformat}
> which can be reproduced with
> {noformat}
> tcase=TestRangeAccumulator -Dtests.method=testMissingValues -Dtests.seed=815B6AA86D05329C -Dtests.slow=true -Dtests.postingsformat=Lucene41 -Dtests.locale=ca -Dtests.timezone=Australia/Currie -Dtests.file.encoding=UTF-8
> {noformat}
> It seems that the Codec that is picked is a Lucene45Codec with Lucene42DVFormat, which does not support docsWithFields for numericDV. We should improve LTC.defaultCodecSupportsDocsWithField to take a list of fields and check that the actual DVF used for each field supports it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org