You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/09/05 06:08:02 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #34096: docs(providers/microsoft): improve documentation for Azure Service Bus hooks DefaultAzureCredential support

uranusjr commented on code in PR #34096:
URL: https://github.com/apache/airflow/pull/34096#discussion_r1315407966


##########
docs/apache-airflow-providers-microsoft-azure/connections/asb.rst:
##########
@@ -42,9 +45,15 @@ All hooks and operators related to Microsoft Azure Service Bus use ``azure_servi
 Configuring the Connection
 --------------------------
 
-Connection String
+Connection String (optional)
     Specify the Azure Service bus connection string ID used for the initial connection.
     Please find the documentation on how to generate connection string in azure service bus
     `Get connection string
     <https://docs.microsoft.com/en-gb/azure/service-bus-messaging/service-bus-create-namespace-portal#get-the-connection-string.>`_
     Use the key ``connection_string`` to pass in the Connection ID .
+    It can be left out to fall back on ``DefaultAzureCredential``.
+
+Fully Qualified Namespace (optional)
+   Specify the fully qualified Service Bus namespace that the connection is associated with. This is likely to be similar to ``{yournamespace}.servicebus.windows.net``.
+   Use the key ``fully_qualified_namespace`` to pass in the Connection ID .
+   This is required when fallbacking to `DefaultAzureCredential <https://docs.microsoft.com/en-us/python/api/overview/azure/identity-readme?view=azure-python#defaultazurecredential>`_.

Review Comment:
   ```suggestion
      This is required when falling back to `DefaultAzureCredential <https://docs.microsoft.com/en-us/python/api/overview/azure/identity-readme?view=azure-python#defaultazurecredential>`_.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org