You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/03 00:06:36 UTC
Review Request 34958: Moved ingress root handle to a proper location.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34958/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, Paul Brett, and Cong Wang.
Repository: mesos
Description
-------
Moved ingress root handle to a proper location.
This is because ingress root is not qdisc specific.
Diffs
-----
src/linux/routing/handle.hpp aed810ed97f29fb79d13feb6fa72ce4360e8623b
src/linux/routing/queueing/ingress.hpp 84506fecd01522471a7998176c28bea8f1367aed
src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699
Diff: https://reviews.apache.org/r/34958/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 34958: Moved ingress root handle to a proper
location.
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34958/#review86307
-----------------------------------------------------------
Ship it!
Ship It!
- Paul Brett
On June 2, 2015, 10:06 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34958/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 10:06 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Paul Brett, and Cong Wang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved ingress root handle to a proper location.
>
> This is because ingress root is not qdisc specific.
>
>
> Diffs
> -----
>
> src/linux/routing/handle.hpp aed810ed97f29fb79d13feb6fa72ce4360e8623b
> src/linux/routing/queueing/ingress.hpp 84506fecd01522471a7998176c28bea8f1367aed
> src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699
>
> Diff: https://reviews.apache.org/r/34958/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34958: Moved ingress root handle to a proper
location.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34958/#review86308
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34956, 34957, 34958]
All tests passed.
- Mesos ReviewBot
On June 2, 2015, 10:06 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34958/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 10:06 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Paul Brett, and Cong Wang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved ingress root handle to a proper location.
>
> This is because ingress root is not qdisc specific.
>
>
> Diffs
> -----
>
> src/linux/routing/handle.hpp aed810ed97f29fb79d13feb6fa72ce4360e8623b
> src/linux/routing/queueing/ingress.hpp 84506fecd01522471a7998176c28bea8f1367aed
> src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699
>
> Diff: https://reviews.apache.org/r/34958/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>