You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/10 14:15:08 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #1684: HDDS-4576. TestDefaultCertificateClient misuses chars param of random()
adoroszlai opened a new pull request #1684:
URL: https://github.com/apache/ozone/pull/1684
## What changes were proposed in this pull request?
1. Allow `random()` to generate strings using all characters.
2. Fix test failure by specifying UTF-8 encoding when calling `String.getBytes()`.
https://issues.apache.org/jira/browse/HDDS-4576
## How was this patch tested?
Reproduced HDDS-1087 by removing `chars` argument:
https://github.com/adoroszlai/hadoop-ozone/runs/1530939654#step:3:3638
Verified the new fix:
https://github.com/adoroszlai/hadoop-ozone/runs/1530664863#step:3:3779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on pull request #1684: HDDS-4576. TestDefaultCertificateClient misuses chars param of random()
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on pull request #1684:
URL: https://github.com/apache/ozone/pull/1684#issuecomment-744743100
LGTM, +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao merged pull request #1684: HDDS-4576. TestDefaultCertificateClient misuses chars param of random()
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #1684:
URL: https://github.com/apache/ozone/pull/1684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1684: HDDS-4576. TestDefaultCertificateClient misuses chars param of random()
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1684:
URL: https://github.com/apache/ozone/pull/1684#issuecomment-745063612
Thanks @xiaoyuyao for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org