You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/02 10:55:58 UTC
[GitHub] [flink-web] zentol opened a new pull request, #579: Add Elasticsearch connector 3.0.0
zentol opened a new pull request, #579:
URL: https://github.com/apache/flink-web/pull/579
Also extends the download page to list connector releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] zentol commented on a diff in pull request #579: Add Elasticsearch connector 3.0.0
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #579:
URL: https://github.com/apache/flink-web/pull/579#discussion_r1016497788
##########
_config.yml:
##########
@@ -611,6 +623,12 @@ release_archive:
version_long: 2.0.0
release_date: 2020-04-02
+ connectors:
+ - name: "Flink Elasticsearch Connector"
+ connector: "elasticsearch"
+ version: 3.0.0
+ release_date: 2022-11-05
Review Comment:
As for announcing it, twitter/slack messages should be good for this. They are well suited for "bursty" announcement, which these will likely be.
Alternatively we could wait with the first big Flink announcement until we have released all other connectors for said version.
So, 1.17 is released (without much fanfare) -> release connectors (without much fanfare) -> announce release :tada: :tada: .
Anyway, this is something better discussed on the ML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] zentol merged pull request #579: Add Elasticsearch connector 3.0.0
Posted by GitBox <gi...@apache.org>.
zentol merged PR #579:
URL: https://github.com/apache/flink-web/pull/579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] zentol commented on a diff in pull request #579: Add Elasticsearch connector 3.0.0
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #579:
URL: https://github.com/apache/flink-web/pull/579#discussion_r1013727088
##########
_config.yml:
##########
@@ -611,6 +623,12 @@ release_archive:
version_long: 2.0.0
release_date: 2020-04-02
+ connectors:
+ - name: "Flink Elasticsearch Connector"
+ connector: "elasticsearch"
+ version: 3.0.0
+ release_date: 2022-11-05
Review Comment:
> In terms of the release itself, I assume we will still require some form of sanity check.
That's entirely up to us; there are no requirements from the ASF side on that matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] zentol commented on a diff in pull request #579: Add Elasticsearch connector 3.0.0
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #579:
URL: https://github.com/apache/flink-web/pull/579#discussion_r1013415427
##########
downloads.md:
##########
@@ -107,6 +107,28 @@ Please have a look at the [Release Notes for Flink {{ flink_release.version_shor
{% endfor %}
+## Flink connectors
Review Comment:
Left it intentionally in case changes are requested. Will sync it in before the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] dannycranmer commented on a diff in pull request #579: Add Elasticsearch connector 3.0.0
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on code in PR #579:
URL: https://github.com/apache/flink-web/pull/579#discussion_r1013352153
##########
downloads.md:
##########
@@ -107,6 +107,28 @@ Please have a look at the [Release Notes for Flink {{ flink_release.version_shor
{% endfor %}
+## Flink connectors
Review Comment:
You missed `downloads.zh.md`
##########
_config.yml:
##########
@@ -611,6 +623,12 @@ release_archive:
version_long: 2.0.0
release_date: 2020-04-02
+ connectors:
+ - name: "Flink Elasticsearch Connector"
+ connector: "elasticsearch"
+ version: 3.0.0
+ release_date: 2022-11-05
Review Comment:
Do we need to include Flink version here? Thinking it might be useful for the case when `3.0.0-1.16` is live and Flink 1.17 is released. We would follow with `3.0.0-1.17`. In this case we have two `3.0.0` versions of the connector and a single release date listed in the docs. We might want to see:
- 3.0.0 for Flink 1.15 and 1.16 released on 2022-11-05
- 3.0.0 for Flink 1.17 released on 2023-01-28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] zentol commented on a diff in pull request #579: Add Elasticsearch connector 3.0.0
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #579:
URL: https://github.com/apache/flink-web/pull/579#discussion_r1013415137
##########
_config.yml:
##########
@@ -611,6 +623,12 @@ release_archive:
version_long: 2.0.0
release_date: 2020-04-02
+ connectors:
+ - name: "Flink Elasticsearch Connector"
+ connector: "elasticsearch"
+ version: 3.0.0
+ release_date: 2022-11-05
Review Comment:
That would still be one release. We'd just publish an additional set of jars afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] dannycranmer commented on a diff in pull request #579: Add Elasticsearch connector 3.0.0
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on code in PR #579:
URL: https://github.com/apache/flink-web/pull/579#discussion_r1013497201
##########
_config.yml:
##########
@@ -611,6 +623,12 @@ release_archive:
version_long: 2.0.0
release_date: 2020-04-02
+ connectors:
+ - name: "Flink Elasticsearch Connector"
+ connector: "elasticsearch"
+ version: 3.0.0
+ release_date: 2022-11-05
Review Comment:
In that case we should consider how we announce it. Users might be waiting for certain connectors and will need a means of notification. Maybe a slack message on announce and email to the mailing list will suffice.
Tangential: In terms of the release itself, I assume we will still require some form of sanity check. We will still need to check the artifacts are good and signing keys are correct. Given the guidance on the [Flink wiki](https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Release):
> Some of these are strictly required for a release to be ASF compliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org