You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Noble Paul <no...@gmail.com> on 2015/05/12 19:58:28 UTC
Why morphlines code is in Solr?
The Morphlines contrib that we have in Solr is copied over from Morphlines.
The files are exactly same. Isn't it better to just have a jar dependency
on that project?
--
-----------------------------------------------------
Noble Paul
RE: Why morphlines code is in Solr?
Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi,
I think his question was why the morphlines contrib *source code* is in Solr at all. He argues that we could simply fetch the pre-built contrib module from Maven and not have a fork of the whole module in Solr.
Indeed I also don't like it that there are 2 almost similar variants of the morphlines contrib...
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Shawn Heisey [mailto:apache@elyograg.org]
> Sent: Tuesday, May 12, 2015 11:59 PM
> To: dev@lucene.apache.org
> Subject: Re: Why morphlines code is in Solr?
>
> On 5/12/2015 2:14 PM, Noble Paul wrote:
> > When I said jar dependency , I did not mean , that we check in the jar
> >
> > we use httpclient, but if you checkout lucene trunk you don't get the
> > httpclient jar ,but the build process will add it to the distribution
>
> Doesn't that describe what happens with morphlines? The build process
> adds it to the distribution.
>
> If I'm completely missing the point of what you're saying, I'll shut up and let
> you elaborate and discuss it with other people who know what's going on.
>
> Thanks,
> Shawn
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Why morphlines code is in Solr?
Posted by Noble Paul <no...@gmail.com>.
https://github.com/kite-sdk/kite/tree/master/kite-morphlines/kite-morphlines-solr-core/src/main/java/org/kitesdk/morphline/solr
and here is the Solr codebase
https://github.com/apache/lucene-solr/tree/trunk/solr/contrib/morphlines-core/src/java/org/apache/solr/morphlines/solr
essentially the same files are there in both codebase. Ideally, the source
should be maintained in one project and the jar should be referred from the
other project
--Noble
On Wed, May 13, 2015 at 3:29 AM, Shawn Heisey <ap...@elyograg.org> wrote:
> On 5/12/2015 2:14 PM, Noble Paul wrote:
> > When I said jar dependency , I did not mean , that we check in the jar
> >
> > we use httpclient, but if you checkout lucene trunk you don't get the
> > httpclient jar ,but the build process will add it to the distribution
>
> Doesn't that describe what happens with morphlines? The build process
> adds it to the distribution.
>
> If I'm completely missing the point of what you're saying, I'll shut up
> and let you elaborate and discuss it with other people who know what's
> going on.
>
> Thanks,
> Shawn
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
-----------------------------------------------------
Noble Paul
Re: Why morphlines code is in Solr?
Posted by Shawn Heisey <ap...@elyograg.org>.
On 5/12/2015 2:14 PM, Noble Paul wrote:
> When I said jar dependency , I did not mean , that we check in the jar
>
> we use httpclient, but if you checkout lucene trunk you don't get the
> httpclient jar ,but the build process will add it to the distribution
Doesn't that describe what happens with morphlines? The build process
adds it to the distribution.
If I'm completely missing the point of what you're saying, I'll shut up
and let you elaborate and discuss it with other people who know what's
going on.
Thanks,
Shawn
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Why morphlines code is in Solr?
Posted by Noble Paul <no...@gmail.com>.
When I said jar dependency , I did not mean , that we check in the jar
we use httpclient, but if you checkout lucene trunk you don't get the
httpclient jar ,but the build process will add it to the distribution
On Wed, May 13, 2015 at 1:06 AM, Shawn Heisey <ap...@elyograg.org> wrote:
> On 5/12/2015 11:58 AM, Noble Paul wrote:
> > The Morphlines contrib that we have in Solr is copied over from
> > Morphlines. The files are exactly same. Isn't it better to just have a
> > jar dependency on that project?
>
> [solr@bigindy5 src]$ svn co
> https://svn.apache.org/repos/asf/lucene/dev/branches/branch_5x
> .... lots of lines snipped ....
> [solr@bigindy5 src]$ cd branch_5x
> [solr@bigindy5 branch_5x]$ find . -name "*.jar"
> [solr@bigindy5 branch_5x]$
>
> There are no jars in a clean source checkout.
>
> [solr@bigindy5 branch_5x]$ cd solr
> [solr@bigindy5 solr]$ ant clean dist
> .... lots of lines snipped ....
>
> At this point, after I have built the solr distribution, if I repeat the
> find command looking for jars, there are quite a lot of them. I believe
> that the third-party jars are included in the contrib directory in the
> download so that an end user doesn't have to scour the Internet looking
> for dependencies, they are included in the Solr download. I'm
> reasonably sure that those jars are retrieved during the compile by ivy,
> and the version retrieved is determined by the ivy config found in the
> lucene directory.
>
> Thanks,
> Shawn
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
-----------------------------------------------------
Noble Paul
Re: Why morphlines code is in Solr?
Posted by Shawn Heisey <ap...@elyograg.org>.
On 5/12/2015 11:58 AM, Noble Paul wrote:
> The Morphlines contrib that we have in Solr is copied over from
> Morphlines. The files are exactly same. Isn't it better to just have a
> jar dependency on that project?
[solr@bigindy5 src]$ svn co
https://svn.apache.org/repos/asf/lucene/dev/branches/branch_5x
.... lots of lines snipped ....
[solr@bigindy5 src]$ cd branch_5x
[solr@bigindy5 branch_5x]$ find . -name "*.jar"
[solr@bigindy5 branch_5x]$
There are no jars in a clean source checkout.
[solr@bigindy5 branch_5x]$ cd solr
[solr@bigindy5 solr]$ ant clean dist
.... lots of lines snipped ....
At this point, after I have built the solr distribution, if I repeat the
find command looking for jars, there are quite a lot of them. I believe
that the third-party jars are included in the contrib directory in the
download so that an end user doesn't have to scour the Internet looking
for dependencies, they are included in the Solr download. I'm
reasonably sure that those jars are retrieved during the compile by ivy,
and the version retrieved is determined by the ivy config found in the
lucene directory.
Thanks,
Shawn
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org