You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2015/03/04 17:55:36 UTC
Review Request 31729: UI doesn't send PUT request if last config is
removed from "slider-client"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31729/
-----------------------------------------------------------
Review request for Ambari and Alexandr Antonenko.
Bugs: AMBARI-9927
https://issues.apache.org/jira/browse/AMBARI-9927
Repository: ambari
Description
-------
*Steps to reproduce:*
1. Add some property to slider-client configuration.
2. Click "Save" button
3. Remove this config via UI
4. Click "Save" button
*Result:*
UI doesn't send PUT request
*Browser console:*
Uncaught Error: assertion failed: You must pass at least an object and event name to Ember.addListener
Diffs
-----
ambari-web/app/controllers/main/service/info/configs.js c325afe453e6e2b1f5b336ae6836d2bf289964c7
ambari-web/app/views/common/controls_view.js 809c72fb7c885e21dadf9f96a534b43bfbdbb9ae
ambari-web/app/views/main/service/item.js dc9f6387d46d8747e0bc1af73d10ebc55d76c1f8
Diff: https://reviews.apache.org/r/31729/diff/
Testing
-------
5470 tests complete (8 seconds)
62 tests pending
Thanks,
Andriy Babiichuk
Re: Review Request 31729: UI doesn't send PUT request if last config
is removed from "slider-client"
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31729/#review75185
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On March 4, 2015, 4:55 p.m., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31729/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 4:55 p.m.)
>
>
> Review request for Ambari and Alexandr Antonenko.
>
>
> Bugs: AMBARI-9927
> https://issues.apache.org/jira/browse/AMBARI-9927
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *Steps to reproduce:*
> 1. Add some property to slider-client configuration.
> 2. Click "Save" button
> 3. Remove this config via UI
> 4. Click "Save" button
>
> *Result:*
> UI doesn't send PUT request
>
> *Browser console:*
> Uncaught Error: assertion failed: You must pass at least an object and event name to Ember.addListener
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js c325afe453e6e2b1f5b336ae6836d2bf289964c7
> ambari-web/app/views/common/controls_view.js 809c72fb7c885e21dadf9f96a534b43bfbdbb9ae
> ambari-web/app/views/main/service/item.js dc9f6387d46d8747e0bc1af73d10ebc55d76c1f8
>
> Diff: https://reviews.apache.org/r/31729/diff/
>
>
> Testing
> -------
>
> 5470 tests complete (8 seconds)
> 62 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>