You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org> on 2017/02/09 11:03:41 UTC

[jira] [Commented] (RANGER-1351) loggers should be "private final static" fields

    [ https://issues.apache.org/jira/browse/RANGER-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859359#comment-15859359 ] 

Colm O hEigeartaigh commented on RANGER-1351:
---------------------------------------------

Please mark the review board request as "submitted".

Colm.

> loggers should be "private final static" fields
> -----------------------------------------------
>
>                 Key: RANGER-1351
>                 URL: https://issues.apache.org/jira/browse/RANGER-1351
>             Project: Ranger
>          Issue Type: Improvement
>          Components: Ranger
>            Reporter: Zsombor Gegesy
>            Assignee: Zsombor Gegesy
>            Priority: Minor
>              Labels: code-cleanup
>             Fix For: 0.7.0
>
>
> There are lot's of places, where the logger is defined either public, or non-final, however the general recommendation is to use as private static final fields.
> Review request: https://reviews.apache.org/r/56309/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)