[GitHub] [ozone] elek commented on a change in pull request #2052: HDDS-4985. [SCM HA Security] When Ratis enable, SCM secure cluster is not working.

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #2052:
URL: https://github.com/apache/ozone/pull/2052#discussion_r616570112



##########
File path: hadoop-ozone/dist/src/main/compose/ozonesecure/test.sh
##########
@@ -27,39 +27,42 @@ export SECURITY_ENABLED=true
 
 : ${OZONE_BUCKET_KEY_NAME:=key1}
 
-start_docker_env
+for enable in true false; do

Review comment:
       This trick doubled the execution time of the secure acceptance test which was already 50 min. It increased the full build time with ~50 mins and (because the parallel execution assumed all the tests finish in 1 hour) the full build is also slower with 30-40 minutes. 
   
   Do we really need this trick?
   
   (By the way the `enable` variable name is not very expressive, and it should be added to the `-N` because different tests will overwrite the results of each other) 
   
   cc @adoroszlai @bharatviswa504 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org