You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Ivan Lyutov <iv...@gmail.com> on 2014/06/02 15:40:24 UTC

Review Request 22131: Patch for KAFKA-1477

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1477
    https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description
-------

Added SSL for Kafka

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.

KAFKA-924. Specify console consumer properties via a single --property command line parameter; reviewed by Neha Narkhede


KAFKA-1459 kafka.tools.ConsumerOffsetChecker throws NoNodeException; reviewed by Neha Narkhede


KAFKA-1444 kafka.javaapi.TopicMetadata and PartitionMetadata doesn't forward the toString method; reviewed by Neha Narkhede


KAFKA-1456 Add LZ4 and LZ4C as a compression codec patch by James Oliver reviewed by Joe Stein


KAFKA-1446 Consumer metrics for rebalance; reviewed by Neha Narkhede and Joel Koshy


KAFKA-1298 Controlled shutdown tool doesn't seem to work out of the box; reviewed by Neha Narkhede


KAFKA-1328 follow up: Updated javadoc


KAFKA-1328 New consumer APIs; reviewed by Jun Rao and Guozhang Wang


kafka-1453 (2nd follow-up); Add a channel queue jmx in Mirror Maker;  patched by Guozhang Wang; reviewed by Jun Rao


kafka-1453 (follow-up); Add a channel queue jmx in Mirror Maker;  patched by Guozhang Wang; reviewed by Jun Rao


kafka-1453; Add a channel queue jmx in Mirror Maker;  patched by Guozhang Wang; reviewed by Jun Rao


KAFKA-1179 createMessageStreams() in javaapi.ZookeeperConsumerConnector does not throw; reviewed by Neha Narkhede


KAFKA-1445 Send all partitions, regardless of how full, whenever we are sending a request to a broker. Patch from Guozhang.


KAFKA-1431 ConsoleConsumer - Option to clean zk consumer path;reviewed by Neha Narkhede and Jun Rao


KAFKA-1437; Consumer metadata response should include (empty) coordinator information if the coordinator is unavailable; reviewed by Neha Narkhede and Guozhang Wang.


kafka-1396; fix transient unit test ProducerFailureHandlingTest.testBrokerFailure;  patched by Guozhang Wang; reviewed by Jun Rao


KAFKA-1442 RBTools post-review is deprecated; reviewed by Neha Narkhede


kafka-1432; followup patch to enable new producer in system test;  patched by Guozhang Wang; reviewed by Neha Narkhede, Jun Rao


KAFKA-1432 followup - Fixing the shutdown sequence furthermore; reviewed by Neha Narkhede


kafka-1384; Log Broker state; followup commit to add the missing new file


kafka-1384; Log Broker state; patched by Timothy Chen; reviewed by Joel Koshy and Jun Rao


kafka-1397; delete topic is not working; patched by Timothy Chen; reviewed by Neha Narkhede and Jun Rao


KAFKA-1432 Make num.producerThreads configurable on new MirrrorMaker; reviewed by Neha Narkhede, Jun Rao


kafka-1146; toString() on KafkaStream gets stuck indefinitely; patched by Arup Malakar; reviewed by Jun Rao


kafka-1412; transient unit test failure in ProducerSendTest.testAutoCreateTopic; patched by Jun Rao; reviewed by Guozhang Wang and Neha Narkhede


KAFKA-1425; Expose metric for LogStartOffset; reviewed by Joel Koshy and Jun Rao


kafka-1433; transient unit test failure in ZookeeperConsumerConnectorTest; patched by Jun Rao; reviewed by Guozhang Wang


kafka-1400; transient unit test failure in SocketServerTest; patched by Neha Narkhede; reviewed by Guozhang and Jun Rao


KAFKA-1428 Ensure we close the file handle when reading the config.


kafka-1383; transient unit test failure in SocketServerTest; patched by Jun Rao; reviewed by Guozhang Wang and Neha Narkhede


kafka-1424; (followup patch) transient unit test failure in testSendWithDeadBroker; patched by Jun Rao; reviewed by Guozhang Wang and Neha Narkhede


kafka-1395; fix unit tests in AutoOffsetResetTest; patched by Guozhang Wang; reviewed by Neha Narkhede, Jun Rao


kafka-1392; all TestUtiles.waitUntilTrue() should throw an exception if the return value is false; patched by Jun Rao; reviewed by Guozhang Wang, Neha Narkhede and Joel Koshy


kafka-1409; oversized messages can slow down the brokers; patched by Guozhang Wang; reviewed by Neha Narkhede, Jun Rao


kafka-1424; transient unit test failure in testSendWithDeadBroker; patched by Jun Rao; reviewed by Timothy Chen


kafka-1418; transient unit test failure in ProducerFailureHandlingTest; patched by Jun Rao; reviewed by Guozhang Wang and Joel Koshy


kafka-1389; transient unit test failure in ProducerFailureHandlingTest; patched by Jun Rao; reviewed by Guozhang Wang and Neha Narkhede


kafka-1359; Followup on K1359: change nanoTime to currentTimeMillis in metrics; patched by Guozhang Wang; reviewed by Neha Narkhede, Jun Rao


kafka-1410; MetadataCache cleanup; patched by Jun Rao; reviewed by Timothy Chen, Joel Koshy


kafka-1411; remove unused test cases; patched by Jun Rao; reviewed by Guozhang Wang


KAFKA-1327; Log cleaner metrics follow-up patch to reset dirtiest log cleanable ratio; reviewed by Jun Rao (cherry picked from commit 874620d)


KAFKA-1398 Dynamic config follow-on-comments.


KAFKA-1362; Publish sources and javadoc jars; (also removed Scala 2.8.2-specific actions). Reviewed by Jun Rao and Joe Stein


KAFKA-1337: Fix incorrect producer configs after config renaming.


KAFKA-1398 dynamic config changes are broken.


KAFKA-1323; Fix regression due to KAFKA-1315 (support for relative directories in log.dirs property broke). Patched by Timothy Chen and Guozhang Wang; reviewed by Joel Koshy, Neha Narkhede and Jun Rao.


KAFKA-1359: Ensure all topic/server metrics registered at once.


kafka-1390; TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs; patched by Jun Rao; reviewed by Guozhang Wang


kafka-1210; Windows Bat files are not working properly; patched by Stevo Slavic; reviewed by Jun Rao


kafka-1381; transient unit test failure in AddPartitionsTest; patched by Jun Rao; reviewed by Neha Narkhede


kafka-1378; transient unit test failure in LogRecoveryTest; patched by Jun Rao; reviewed by Neha Narkhede


kafka-1377; transient unit test failure in LogOffsetTest; patched by Jun Rao; reviewed by Neha Narkhede


trivial change to add kafka doap project file


kafka-1363; testTopicConfigChangesDuringDeleteTopic hangs; patched by Timothy Chen; reviewed by Guozhang Wang, Neha Narkhede and Jun Rao


kafka-1337; follow-up patch to add broker list for new producer in system test overriden function; patched by Guozhang Wang; reviewed by Neha Narkhede, Jun Rao


kafka-1353;report capacity used by request thread pool and network thread pool; patched by Guozhang Wang; reviewed by Jun Rao


kafka-1376; transient test failure in UncleanLeaderElectionTest; patched by Jun Rao; reviewed by Joel Koshy


kafka-1364; ReplicaManagerTest hard-codes log dir; patched by Guozhang Wang; reviewed by Jun Rao


KAFKA-1373; Set first dirty (uncompacted) offset to first offset of the log if no checkpoint exists. Reviewed by Neha Narkhede and Timothy Chen.


kafka-1375; Formatting for in README.md is broken; patched by Stevo Slavic; reviewed by Jun Rao


kafka-1370; Gradle startup script for Windows; patched by Stevo Slavic; reviewed by Jun Rao


kafka-1371; Ignore build output dirs; patched by Stevo Slavic; reviewed by Jun Rao


kafka-1352; Reduce logging on the server; patched by Ivan Lyutovg; reviewed by Guozhang Wang and Jun Rao


Trivial: update javadoc comment for KAFKA-1355


KAFKA-1356 Topic metadata requests takes too long to process; reviewed by Neha Narkhede, Joel Koshy and Guozhang Wang


KAFKA-1366 Multiple Unit Test failures with new producer; reviewed by Neha Narkhede


kafka-1337 followup to fix system tests


KAFKA-1355; Avoid sending all topic metadata on state changes. Reviewed by Neha Narkhede and Timothy Chen


KAFKA-1337 Rationalize the producer configs.


kafka-1344; Kafka-console-producer.sh support snappy compression; patched by Ivan Lyutovg; reviewed by Jun Rao


KAFKA-1327 Add log cleaner metrics.


KAFKA-1251 Further metric naming standardization.


kafka-1318; waiting for producer to stop is not reliable in system tests; patched by Jun Rao; reviewed by Guozhang Wang, Timothy Chen and Neha Narkhede


KAFKA-1341 Client Selector doesn't check connection id properly; reviewed by Jay Kreps and Neha Narkhede


KAFKA-1350 Fix excessive state change logging;reviewed by Jun,Joel,Guozhang and Tim


kafka-1320; Change compression.codec to compression.type in new producer configs of system tests; patched by Guozhang Wang; reviewed by Jun Rao


KAFKA-1317 KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state; reviewed by Neha Narkhede


KAFKA-1251 Missed one per-node metric.


KAFKA-1251: Add metrics to the producer.


Diffs
-----

  .gitignore 4d3b0ee54829e1f4c6811366faeb150359cd981c 
  README.md dece147e95083661fe42c2d87b54f53694402d4f 
  bin/windows/kafka-console-consumer.bat a287b9e3056e444c91ae40011efbb65983be889c 
  bin/windows/kafka-console-producer.bat b321ee28e8129d03650e50e432d39e5eb4199ad2 
  bin/windows/kafka-run-class.bat f274cd7d883ab63e5247c2fc16f8802a270f9563 
  bin/windows/kafka-server-start.bat 7db76dd44bab5487e29ce70681568b355d365d75 
  bin/windows/kafka-topics.bat PRE-CREATION 
  bin/windows/zookeeper-server-start.bat 0dd40ba7bb08c52182ac91f1c8b17b9556178847 
  build.gradle 5432c0ccbf140919467553331741e2d2257725e3 
  clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceCallback.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/OffsetMetadata.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 1ff9174870a8c9cd97eb6655416edd4124377b0e 
  clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java 6a0f3b27f754d340aa133218204470a822d4d747 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 48706baa5eeee2f9c29e2fec7a81bb090ddd21ae 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/FutureRecordMetadata.java aec31c381658f85ab6394a6475b4989177a31a3d 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java 33d62a4b83fbab5b22b91b22f6b744af1c98d262 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java fbb732a57522109ac0e0eaf5c87b50cbd3a7f767 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java 50bf95feab93a42c20ccef9299348dfd37728f11 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java 35f1d7a6c5b9021d48c22231769664e7e25d6c52 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 565331dfb9cd1d65be37ed97830aa42e44d2e127 
  clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java 05085e02705c59c5fb5bd19d05c5baa88bfc0af8 
  clients/src/main/java/org/apache/kafka/common/Cluster.java 426bd1eec708979149cbd6fa3959e6f9e73c7e0e 
  clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java 84a327e8c1f06840492abc38e5cb0446cfbc7541 
  clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java 67b349dc8d840b0b7bfb4bedde819e092dc48d21 
  clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3950eb13d37e41276db9b4d2db24c2b1f4118fc2 
  clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java b2426ac9274688b3a658fd03ff5e57cd5dea5c93 
  clients/src/main/java/org/apache/kafka/common/metrics/Measurable.java 0f405c3f81314c14688045737857865c455b6073 
  clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java 4d14fbcc68a806ef86a692b3d032fd3d8f06b6d6 
  clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 6db2dfbe94c940efa37463298f0b0b1893e646e1 
  clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java 2c395b1f8f3434625959f70d2f4fec40857270e8 
  clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 7e4849b7a148009c8a878349d7f0239108ccad8c 
  clients/src/main/java/org/apache/kafka/common/metrics/Stat.java e02389c969f52e3ee9627fd99999bf78f2470878 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Avg.java 51725b278495f1cb4b492e98847056e61614f4e7 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Count.java 3cdd1d054e0b989bb1c2ab3c63944c3861896099 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Max.java bba59721faa146758dd0b9c30e2d7a8354ca6fc8 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Min.java d370049a7f1c0905a64c00131af05e44566026ec 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java 4d549167ea7c1390ecf1440e40332375f247088f 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java 3b0454f26490d1f4a2a80efb00165fc72587fbf8 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java f8b413a8c273cdad56177fbc6971fece4feb86b3 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Total.java a9940ed7ea1db2c1340ec110b62a6a9efeb4c52d 
  clients/src/main/java/org/apache/kafka/common/network/ByteBufferSend.java 9305b61ddeaa2bb400cbbb6d3c99c8ecaade6b8f 
  clients/src/main/java/org/apache/kafka/common/network/NetworkReceive.java 51d4892dfc18580e5e213d386c5de387a47d3c6b 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 983963200ce81614577cd6182a5d2f10c22b95d4 
  clients/src/main/java/org/apache/kafka/common/record/CompressionType.java c557e44b68bc201c7c7e8a31e9eb2f74c359762b 
  clients/src/main/java/org/apache/kafka/common/record/Compressor.java 6ae3d06ac6d27e4ecee3f5b4a18e2615d0581442 
  clients/src/main/java/org/apache/kafka/common/record/Record.java ce1177ef3c851572a3e3268a7a075e7db56fc3f7 
  clients/src/main/java/org/apache/kafka/common/utils/ClientUtils.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/utils/CopyOnWriteMap.java 187d22fba5fe225546738fbf43b25fa9e5b4f334 
  clients/src/main/java/org/apache/kafka/common/utils/SystemTime.java 6582c73dab6344e0796109f804cb726480c6b235 
  clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerExampleTest.java PRE-CREATION 
  clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java 09a5355d25a3b94c8e23caa2adc77cb1c59368b9 
  clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java ed5690641a22fbe4bd91b0c6055d465944b08c06 
  clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java 12c9500ce4387306ab5aa7a5781b4aca52b86604 
  clients/src/test/java/org/apache/kafka/common/config/ConfigDefTest.java 29543dfa34d5f26397d9327d4e8d0c87b28b1fa9 
  clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java fdd89141579b6ab2bfaf2b1588440909ae0a7bfd 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 90e2dcf5434db546387302fb0219edfdb363592e 
  clients/src/test/java/org/apache/kafka/common/utils/AbstractIteratorTest.java 1df226606fad29da47d81d0b8ff36209c3536c06 
  clients/src/test/java/org/apache/kafka/test/MetricsBench.java 7239b4a56e93f019e66aa2cf2aa9b04c26908bfd 
  clients/src/test/java/org/apache/kafka/test/Microbenchmarks.java 46cf86e67e5ee3a8bc841b1d66897862fe1233cf 
  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
  config/log4j.properties baa698b64259b18efed372cf009a04613b6c53cf 
  config/producer.properties 52a76114f5d0968ca0ff01b3ab1a45450c0a1e33 
  config/server.keystore PRE-CREATION 
  config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  contrib/LICENSE PRE-CREATION 
  contrib/NOTICE PRE-CREATION 
  contrib/hadoop-consumer/LICENSE 6b0b1270ff0ca8f03867efcd09ba6ddb6392b1e1 
  contrib/hadoop-producer/LICENSE 6b0b1270ff0ca8f03867efcd09ba6ddb6392b1e1 
  core/src/main/scala/kafka/admin/AdminUtils.scala 36ddeb44490e8343a4e8056c45726ac660e4b2f9 
  core/src/main/scala/kafka/admin/ShutdownBroker.scala 2dd47e7362f42b434ec8bb6b93f0cb0cb1a50a28 
  core/src/main/scala/kafka/admin/TopicCommand.scala 686a0dfc65b036263375db7f64f1f2bae42199b0 
  core/src/main/scala/kafka/api/ConsumerMetadataResponse.scala 6807f9806fb155f6cdb1aaf63c14ac8ec180d779 
  core/src/main/scala/kafka/api/FetchRequest.scala dea118a2e37927d4268e1a2506e698bc17671d75 
  core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 03117377e1cb2ad63e4c7740d97ca9a4f20abeeb 
  core/src/main/scala/kafka/api/RequestOrResponse.scala 708e547a358c95f1a68fc507a88544fbaa21a938 
  core/src/main/scala/kafka/api/TopicMetadata.scala 0513a59ed94e556894b3515dc38666ee9a66ae3d 
  core/src/main/scala/kafka/client/ClientUtils.scala fc9e08423a4127e1d64be1e62def567ea9eb80a3 
  core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
  core/src/main/scala/kafka/cluster/Partition.scala 0b88f14c4855b27242906cd45930bae501e26226 
  core/src/main/scala/kafka/common/MessageStreamsExistException.scala PRE-CREATION 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 0f62819be0562f62c0f778bd20ead053f01a6f2f 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/KafkaStream.scala 31eaf866e3c84f1398803b2b9b453f21250a5a9c 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala ff5e81943e10ef37de16f657aeecc25e17d3e83a 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8ab8ab66bda1e13986df9b88d49199136833de97 
  core/src/main/scala/kafka/controller/KafkaController.scala 7dc27186dec23eccef934b0a1af9f320553e6c7c 
  core/src/main/scala/kafka/controller/PartitionStateMachine.scala c3e8d05102c38045df48936655291bc0f61da84f 
  core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 37a48005b3e3c7d13e4af21a8117144948271874 
  core/src/main/scala/kafka/controller/TopicDeletionManager.scala 488dfd08d9956dab2fb1ed3925d138cda637509d 
  core/src/main/scala/kafka/javaapi/ConsumerMetadataResponse.scala dfa9c42bcab39b56775fddedea1137a518349386 
  core/src/main/scala/kafka/javaapi/TopicMetadata.scala d08c3f4af51e742ac441e65c97d547f097c169ca 
  core/src/main/scala/kafka/javaapi/TopicMetadataResponse.scala 252a0c9d6c12b5e79426b7eca85ab0bb067b42b0 
  core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala 1f95d9b6a560b353dbd7fe8ad08495d47f9e1ac2 
  core/src/main/scala/kafka/log/Log.scala b3ab5220a66a2ae82084dad89877daf60f613e66 
  core/src/main/scala/kafka/log/LogCleaner.scala 312204c6ddd0cf46cd7349d79a43edec839bc361 
  core/src/main/scala/kafka/log/LogCleanerManager.scala 43e5c1fd6d9d99f6a47af2136a3d15b9799d4947 
  core/src/main/scala/kafka/log/LogManager.scala 8ed9b68e763aa14e3ef282eec738fa190eb20132 
  core/src/main/scala/kafka/message/CompressionCodec.scala 8762a790af2ab7f60a5e4e19955c7eb7ad7bc749 
  core/src/main/scala/kafka/message/CompressionFactory.scala ca833ee317975548b3e0e91f010af36bce2af09b 
  core/src/main/scala/kafka/message/Message.scala 52c082f5213ba48a39bf0d17e4ced2714276f0e0 
  core/src/main/scala/kafka/message/MessageSet.scala a1b5c63b4d9deaa2556427d995c41841838cf581 
  core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/RequestChannel.scala a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748 
  core/src/main/scala/kafka/network/SocketServer.scala dcfca3f4156957b0006ba9bfdeca848c115825a8 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
  core/src/main/scala/kafka/producer/BaseProducer.scala PRE-CREATION 
  core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 988e4374d8c9b30c9333369741c30c75f0c44f2c 
  core/src/main/scala/kafka/producer/ConsoleProducer.scala 57386b16988afa17792888fbebb285c174b117f4 
  core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala 0067a5375ed33d7831548450d80bee13d0196555 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala db7017b8a8ff06384674f36792053e4bc68419f1 
  core/src/main/scala/kafka/server/BrokerStates.scala PRE-CREATION 
  core/src/main/scala/kafka/server/KafkaApis.scala 1d9922b2ef8e7d1f940321be53b3405316d0e492 
  core/src/main/scala/kafka/server/KafkaConfig.scala b0506d4881176cd95914847c4275e428a8d2ca10 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaRequestHandler.scala 871212bf9110ca95ca7d2109be070f69d0f90247 
  core/src/main/scala/kafka/server/KafkaServer.scala c208f83bed7fb91f07fae42f2b66892e6d46fecc 
  core/src/main/scala/kafka/server/KafkaServerStartable.scala acda52b801714bcc182edc0ced925f0e4b493fc1 
  core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION 
  core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0 
  core/src/main/scala/kafka/server/OffsetManager.scala 89a88a7e4055f804429b64e85b2f65312d1e2155 
  core/src/main/scala/kafka/server/ReplicaManager.scala 255be063ee247a849e527297c987da4625d749ca 
  core/src/main/scala/kafka/server/TopicConfigManager.scala d41fd33d91406dfa2ce8c1e1b04a078e983ccadd 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 88f824fa5afe7964efc569bc0732fd40a55c5c93 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
  core/src/main/scala/kafka/tools/MirrorMaker.scala e4d1a86f673f7df7fe71ce44e3550fcde8d01bba 
  core/src/main/scala/kafka/tools/ReplayLogProducer.scala f2246f97beb799f80538a14d878b755b422e88e5 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala a64946108049e7d15f655208a2bc6cabcb1e8720 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
  core/src/main/scala/kafka/tools/TestEndToEndLatency.scala ea856c7112080ae9e348d6f08942fec7b321c081 
  core/src/main/scala/kafka/tools/TestLogCleaning.scala edb6e5f8fe511debd8b971dddb786e684ed7e1ac 
  core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala a969a22c6b82ed5c9f053a50594b1c7a768efd0e 
  core/src/main/scala/kafka/utils/ShutdownableThread.scala cf8adc9f468f4d6f01d1303efe39a3ec6f3d9b53 
  core/src/main/scala/kafka/utils/Throttler.scala c6c3c75ee8408ca81aeeb5846f7987a287b5a6e8 
  core/src/main/scala/kafka/utils/Utils.scala 6bfbac16e2f8d68b8c711a0336c698aa6f610ae8 
  core/src/main/scala/kafka/utils/VerifiableProperties.scala d40b03ca844ebb3e4f91e8bc44bc5edcf4cb292c 
  core/src/main/scala/kafka/utils/ZkUtils.scala 16bf7e3e87b520b31485199b2830494ca5f96c1a 
  core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala 1d73aca658a9ea31e76c3e12575703823ed0428f 
  core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 525a06076bda51eaf001fb0a47091094c06c35f7 
  core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 3c37330a366e84eb3bf0a96ed45de6e3f01b0a71 
  core/src/test/scala/other/kafka/TestOffsetManager.scala c468419297d297c2f320ff6d6dbbc5cd42380aa2 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 115e20305a1540ef8289c916a185056b3c30d237 
  core/src/test/scala/unit/kafka/admin/AdminTest.scala d5644ea40ec7678b975c4775546b79fcfa9f64b7 
  core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala e704290e59dbd42b77c75c70e49a43116119856f 
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala d39a9a4bf89af493122b663f1378b9d01c9440ec 
  core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala 9347ea60f2c02bd01b1c8507e30cb7dfdeaa5d72 
  core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 258dd25a201cd9a9afd96d03a0ad3687c48f6f75 
  core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala e5703bc16b2ce2306395f0c773a0e8a82ac63176 
  core/src/test/scala/unit/kafka/integration/FetcherTest.scala 47130d33c36fabf19ffd94d488fd4281e23b1bdd 
  core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala c3c7631659fbd9265e45aa810d32faafe9aed1d1 
  core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala d44c3ff1d354874ed912dc8df960ff664f652786 
  core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala 731ee59e67e302f4cb1da12b1d4ae7ff59010aea 
  core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala e86ee803ab9c707820fc2d867212d500da760c3a 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 9998a1156d41d6afcaf5674bb9b45e16652c8167 
  core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala c5f2da993918242389fbb25bd903bf479e26f839 
  core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 43af649f3297644e8caea176a79cadde745be2a4 
  core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 9aeb69d4934b9aa94e0899af14fc27e7c20f039f 
  core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
  core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 
  core/src/test/scala/unit/kafka/message/MessageCompressionTest.scala ed22931f24fed3530d374b56495a5e4bc89c72f2 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc 
  core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 18e355501808c00b610da8346e0dd1898d5b9301 
  core/src/test/scala/unit/kafka/producer/ProducerTest.scala 4b2e4ade70f6f3d1804f4627e1eb680f6721c93d 
  core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala 8d63e312d3edac0ee0400b8cf316828c2a5a064f 
  core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala PRE-CREATION 
  core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala a78f7cfa025b0c5d968381b6d5dc7aec894a612b 
  core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala 38e3ae72a87e13f6e1a739cc8c75b781fb004133 
  core/src/test/scala/unit/kafka/server/LogOffsetTest.scala e10228555550d1efc828b8135fb0aa3f19801afc 
  core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala db0e58bb018f2030d06b65fa31461062fd9b1786 
  core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala ae9bb3a69d57143b868ead12d736377a001b1536 
  core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala dd85c718167158ad01f00d9aa6f990bf4ec9a6af 
  core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa 
  core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 20fe93e623319fd82236eb6364d7f80bf7a256aa 
  core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 22bb6f2847b8895f8fbba6c531963ebb0fffe2ca 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 2054c25bbced6bd90c092a1974975732ad346146 
  doap_Kafka.rdf PRE-CREATION 
  gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
  gradlew.bat PRE-CREATION 
  kafka-patch-review.py dc6664d22a0b18f96d7d3513a6d1fe739d45c000 
  perf/src/main/scala/kafka/perf/ProducerPerformance.scala 9e4ebafc4557594d0d87a25e51a9432ef813bb9c 
  system_test/README.txt 87937ecd7d637c62f2d401f54f1d669ac0d13f0a 
  system_test/migration_tool_testsuite/0.7/config/log4j.properties PRE-CREATION 
  system_test/migration_tool_testsuite/config/migration_producer.properties 17b5928a1213fc0cae7cd94cd214323ccca61d48 
  system_test/migration_tool_testsuite/migration_tool_test.py 2386a5884fcf86bac282ef28f07a3af740185f7f 
  system_test/mirror_maker_testsuite/config/mirror_producer.properties 4391bc8b440255dc795d0a944fa9420060238984 
  system_test/producer_perf/config/server.properties 9f8a633ab2f92862e7e7bcc40d699daf00c69e23 
  system_test/utils/kafka_system_test_utils.py 35f2d1b0464edb738cd8e01f8654913776c49459 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
-------


Thanks,

Ivan Lyutov

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44593
-----------------------------------------------------------



core/src/main/scala/kafka/network/security/AuthConfig.scala
<https://reviews.apache.org/r/22131/#comment79013>

    requires apache header


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44590
-----------------------------------------------------------



core/src/main/scala/kafka/network/BlockingChannel.scala
<https://reviews.apache.org/r/22131/#comment79010>

    is this change really required?


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44585
-----------------------------------------------------------



core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
<https://reviews.apache.org/r/22131/#comment79005>

    this shouldn't change, it should be info


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.


> On June 3, 2014, 12:37 p.m., Joe Stein wrote:
> > core/src/main/scala/kafka/network/BlockingChannel.scala, line 80
> > <https://reviews.apache.org/r/22131/diff/3/?file=601681#file601681line80>
> >
> >     ok, then can you make that log line info instead of debug please.  thanks!

never mind, keep it as debug please


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44618
-----------------------------------------------------------


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44618
-----------------------------------------------------------



core/src/main/scala/kafka/network/BlockingChannel.scala
<https://reviews.apache.org/r/22131/#comment79038>

    ok, then can you make that log line info instead of debug please.  thanks!


- Joe Stein


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Rajasekar Elango <e....@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44927
-----------------------------------------------------------



config/server.properties
<https://reviews.apache.org/r/22131/#comment79513>

    Should we secure property to false to make kafka run in non-secure mode by default so it won't impact existing users.


- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Rajasekar Elango <e....@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44914
-----------------------------------------------------------

Ship it!


Looks like the changes we did on this commit https://github.com/relango/kafka/commit/0ec255e94973df995c43818bb09d1246440aded9 is not included in patch. We made those changes to fix BadVersion Error thrown by zookeeper. Hopefully they don't happen anymore with latest code in trunk. If it comes back we can create another patch since it is not related to security. So ok with not including it.

- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Rajasekar Elango <e....@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44920
-----------------------------------------------------------



core/src/main/scala/kafka/network/security/SSLSocketChannel.scala
<https://reviews.apache.org/r/22131/#comment79505>

    Good to see that you already added lines 644 through 656 to make it compile jdk1.7 


- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Rajasekar Elango <e....@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44855
-----------------------------------------------------------


Looks like change to UpdateOffsetsInZK.scala (https://github.com/relango/kafka/compare/0.8-snapshot...kafka_security#diff-43) is not included in the patch (=

- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Rajasekar Elango <e....@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44916
-----------------------------------------------------------

Ship it!


Looks like the changes we did on this commit https://github.com/relango/kafka/commit/0ec255e94973df995c43818bb09d1246440aded9 is not included in patch. We made those changes to fix BadVersion Error thrown by zookeeper. Hopefully they don't happen anymore with latest code in trunk. If it comes back we can create another patch since it is not related to security. So ok with not including it.

- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Rajasekar Elango <e....@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review54285
-----------------------------------------------------------



core/src/main/scala/kafka/tools/ConsoleProducer.scala
<https://reviews.apache.org/r/22131/#comment94287>

    Can you rename **client.security.file** to  **security.config.file** to be consistent with ConsoleConsumer and naming convention used across the code ?


- Rajasekar Elango


On Sept. 23, 2014, 11:14 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 11:14 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Added basic functionality for new producer.
> 
> 
> bug fixes after rebase
> 
> 
> bug fix after rebase
> 
> 
> updated tests after rebase
> 
> 
> changed default security to false
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java f58b8508d3f813a51015abed772c704390887d7e 
>   clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java f9de4af426449cceca12a8de9a9f54a6241d28d8 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java PRE-CREATION 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala 59c09155dd25fad7bed07d3d00039e3dc66db95c 
>   core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde 
>   core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 9ebbee6c16dc83767297c729d2d74ebbd063a993 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala d349a3000feb9ccd57d1f3cb163548d5bf432186 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 42c950375098b51f45c79c6a4a99a36f387bf02b 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 2e9532e820b5b5c63dfd55f5454b32866d084a37 
>   core/src/main/scala/kafka/server/KafkaConfig.scala 165c816a9f4c925f6e46560e7e2ff9cf7591946b 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala 390fef500d7e0027e698c259d777454ba5a0f5e8 
>   core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
>   core/src/main/scala/kafka/tools/ConsoleProducer.scala da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala 9c6064e201eebbcd5b276a0dedd02937439edc94 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala af4783646803e58714770c21f8c3352370f26854 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 
>   core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 2dbdd3c2f03caf1542e38e5e08a21f2a1c8b7657 
>   gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 
>   gradlew c312b910b570f46f0435302cda44295d8903c573 
>   gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Rajasekar Elango <e....@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review54412
-----------------------------------------------------------



core/src/main/scala/kafka/utils/ZkUtils.scala
<https://reviews.apache.org/r/22131/#comment94544>

    Can we please register secure value of broker in zookeeper as a boolean true/false instead of number 1|0? Two reasons for this request 
    1. It's really a boolean, not an number.
    2. It's breaks backward compactibility with our (salesforce's) original implementation. Our older secure client can no longer work with this newer version of secure broker.


- Rajasekar Elango


On Sept. 23, 2014, 11:14 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 11:14 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Added basic functionality for new producer.
> 
> 
> bug fixes after rebase
> 
> 
> bug fix after rebase
> 
> 
> updated tests after rebase
> 
> 
> changed default security to false
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java f58b8508d3f813a51015abed772c704390887d7e 
>   clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java f9de4af426449cceca12a8de9a9f54a6241d28d8 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java PRE-CREATION 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala 59c09155dd25fad7bed07d3d00039e3dc66db95c 
>   core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde 
>   core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 9ebbee6c16dc83767297c729d2d74ebbd063a993 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala d349a3000feb9ccd57d1f3cb163548d5bf432186 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 42c950375098b51f45c79c6a4a99a36f387bf02b 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 2e9532e820b5b5c63dfd55f5454b32866d084a37 
>   core/src/main/scala/kafka/server/KafkaConfig.scala 165c816a9f4c925f6e46560e7e2ff9cf7591946b 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala 390fef500d7e0027e698c259d777454ba5a0f5e8 
>   core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
>   core/src/main/scala/kafka/tools/ConsoleProducer.scala da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala 9c6064e201eebbcd5b276a0dedd02937439edc94 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala af4783646803e58714770c21f8c3352370f26854 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 
>   core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 2dbdd3c2f03caf1542e38e5e08a21f2a1c8b7657 
>   gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 
>   gradlew c312b910b570f46f0435302cda44295d8903c573 
>   gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Ivan Lyutov <iv...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
-----------------------------------------------------------

(Updated Sept. 23, 2014, 11:14 a.m.)


Review request for kafka.


Bugs: KAFKA-1477
    https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
-------

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.

Updated according to requested changes: refactoring, minor edits.


Added basic functionality for new producer.


bug fixes after rebase


bug fix after rebase


updated tests after rebase


changed default security to false


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java f58b8508d3f813a51015abed772c704390887d7e 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java f9de4af426449cceca12a8de9a9f54a6241d28d8 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala 59c09155dd25fad7bed07d3d00039e3dc66db95c 
  core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde 
  core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 9ebbee6c16dc83767297c729d2d74ebbd063a993 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala d349a3000feb9ccd57d1f3cb163548d5bf432186 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
  core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 42c950375098b51f45c79c6a4a99a36f387bf02b 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 2e9532e820b5b5c63dfd55f5454b32866d084a37 
  core/src/main/scala/kafka/server/KafkaConfig.scala 165c816a9f4c925f6e46560e7e2ff9cf7591946b 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala 390fef500d7e0027e698c259d777454ba5a0f5e8 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/ConsoleProducer.scala da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 9c6064e201eebbcd5b276a0dedd02937439edc94 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala af4783646803e58714770c21f8c3352370f26854 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 
  core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 2dbdd3c2f03caf1542e38e5e08a21f2a1c8b7657 
  gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 
  gradlew c312b910b570f46f0435302cda44295d8903c573 
  gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
-------


Thanks,

Ivan Lyutov

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Ivan Lyutov <iv...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
-----------------------------------------------------------

(Updated Sept. 23, 2014, 11:11 a.m.)


Review request for kafka.


Bugs: KAFKA-1477
    https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
-------

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.

Updated according to requested changes: refactoring, minor edits.


Added basic functionality for new producer.


bug fixes after rebase


bug fix after rebase


updated tests after rebase


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java f58b8508d3f813a51015abed772c704390887d7e 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java f9de4af426449cceca12a8de9a9f54a6241d28d8 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala 59c09155dd25fad7bed07d3d00039e3dc66db95c 
  core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde 
  core/src/main/scala/kafka/cluster/Broker.scala 0060add008bb3bc4b0092f2173c469fce0120be6 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 9ebbee6c16dc83767297c729d2d74ebbd063a993 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala d349a3000feb9ccd57d1f3cb163548d5bf432186 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
  core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 42c950375098b51f45c79c6a4a99a36f387bf02b 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 2e9532e820b5b5c63dfd55f5454b32866d084a37 
  core/src/main/scala/kafka/server/KafkaConfig.scala 165c816a9f4c925f6e46560e7e2ff9cf7591946b 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala 390fef500d7e0027e698c259d777454ba5a0f5e8 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/ConsoleProducer.scala da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 9c6064e201eebbcd5b276a0dedd02937439edc94 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala af4783646803e58714770c21f8c3352370f26854 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 
  core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 2dbdd3c2f03caf1542e38e5e08a21f2a1c8b7657 
  gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 
  gradlew c312b910b570f46f0435302cda44295d8903c573 
  gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
-------


Thanks,

Ivan Lyutov

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Rajasekar Elango <e....@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review54191
-----------------------------------------------------------



config/server.properties
<https://reviews.apache.org/r/22131/#comment94187>

    Can we set secure property to ***false*** to make kafka run in non-secure mode by default so it won't impact existing users


- Rajasekar Elango


On Sept. 18, 2014, 12:43 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 12:43 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Added basic functionality for new producer.
> 
> 
> bug fixes after rebase
> 
> 
> bug fix after rebase
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java f58b8508d3f813a51015abed772c704390887d7e 
>   clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java f9de4af426449cceca12a8de9a9f54a6241d28d8 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java PRE-CREATION 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala 51cdccf7f90eb530cc62b094ed822b8469d50b12 
>   core/src/main/scala/kafka/client/ClientUtils.scala ce7ede3f6d60e756e252257bd8c6fedc21f21e1c 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 9ebbee6c16dc83767297c729d2d74ebbd063a993 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 8db9203d164a4a54f94d8d289e070a0f61e03ff9 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala d67899080c21e0b6db84657d6845c7ef23b59b0e 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 2e9532e820b5b5c63dfd55f5454b32866d084a37 
>   core/src/main/scala/kafka/server/KafkaConfig.scala dce48db175d6ea379f848a7768de0b1c8e4b929f 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala 28711182aaa70eaa623de858bc063cb2613b2a4d 
>   core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
>   core/src/main/scala/kafka/tools/ConsoleProducer.scala da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala 9c6064e201eebbcd5b276a0dedd02937439edc94 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala af4783646803e58714770c21f8c3352370f26854 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 
>   core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 3b83a86a773147c9b29b4d271aee480efec748ad 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala c4e13c5240c8303853d08cc3b40088f8c7dae460 
>   gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 
>   gradlew c312b910b570f46f0435302cda44295d8903c573 
>   gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Ivan Lyutov <iv...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
-----------------------------------------------------------

(Updated Sept. 18, 2014, 12:43 p.m.)


Review request for kafka.


Bugs: KAFKA-1477
    https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
-------

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.

Updated according to requested changes: refactoring, minor edits.


Added basic functionality for new producer.


bug fixes after rebase


bug fix after rebase


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java f58b8508d3f813a51015abed772c704390887d7e 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java f9de4af426449cceca12a8de9a9f54a6241d28d8 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala 51cdccf7f90eb530cc62b094ed822b8469d50b12 
  core/src/main/scala/kafka/client/ClientUtils.scala ce7ede3f6d60e756e252257bd8c6fedc21f21e1c 
  core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 9ebbee6c16dc83767297c729d2d74ebbd063a993 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 8db9203d164a4a54f94d8d289e070a0f61e03ff9 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
  core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala d67899080c21e0b6db84657d6845c7ef23b59b0e 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 2e9532e820b5b5c63dfd55f5454b32866d084a37 
  core/src/main/scala/kafka/server/KafkaConfig.scala dce48db175d6ea379f848a7768de0b1c8e4b929f 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala 28711182aaa70eaa623de858bc063cb2613b2a4d 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/ConsoleProducer.scala da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 9c6064e201eebbcd5b276a0dedd02937439edc94 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala af4783646803e58714770c21f8c3352370f26854 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 
  core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 3b83a86a773147c9b29b4d271aee480efec748ad 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala c4e13c5240c8303853d08cc3b40088f8c7dae460 
  gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 
  gradlew c312b910b570f46f0435302cda44295d8903c573 
  gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
-------


Thanks,

Ivan Lyutov

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Ivan Lyutov <iv...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
-----------------------------------------------------------

(Updated June 3, 2014, 10:53 a.m.)


Review request for kafka.


Bugs: KAFKA-1477
    https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
-------

Updated according to requested changes: refactoring, minor edits.


Reverted gradle version


Added SSL for Kafka

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.


Diffs (updated)
-----

  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
  core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
  core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
  core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
  core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
  core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
  core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
-------


Thanks,

Ivan Lyutov

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44594
-----------------------------------------------------------



core/src/main/scala/kafka/network/security/KeyStores.scala
<https://reviews.apache.org/r/22131/#comment79014>

    requires apache header


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44589
-----------------------------------------------------------



core/src/main/scala/kafka/consumer/SimpleConsumer.scala
<https://reviews.apache.org/r/22131/#comment79009>

    can we do this with an atomic bool instead?


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44592
-----------------------------------------------------------



core/src/main/scala/kafka/network/SocketServer.scala
<https://reviews.apache.org/r/22131/#comment79012>

    lots of changes here.  we need to have the minimal set of changes to support the feature.


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44595
-----------------------------------------------------------



gradle/wrapper/gradle-wrapper.properties
<https://reviews.apache.org/r/22131/#comment79015>

    please revert


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44587
-----------------------------------------------------------



core/src/main/scala/kafka/common/UnknownKeyStoreException.scala
<https://reviews.apache.org/r/22131/#comment79007>

    This file needs apache header license please


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44588
-----------------------------------------------------------



core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala
<https://reviews.apache.org/r/22131/#comment79008>

    this should not be part of this ticket


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44586
-----------------------------------------------------------



config/server.properties
<https://reviews.apache.org/r/22131/#comment79006>

    The old property file should be preserved with only the new additions to it please that are required, thanks


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Ivan Lyutov <iv...@gmail.com>.


> On June 3, 2014, 3:14 a.m., Joe Stein wrote:
> > core/src/main/scala/kafka/network/BlockingChannel.scala, line 80
> > <https://reviews.apache.org/r/22131/diff/3/?file=601681#file601681line80>
> >
> >     is this change and the ones below it, are they really required?

Yes. Otherwise, there will be an exception thrown on consumer close.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44591
-----------------------------------------------------------


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Updated according to requested changes: refactoring, minor edits.
> 
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44591
-----------------------------------------------------------



core/src/main/scala/kafka/network/BlockingChannel.scala
<https://reviews.apache.org/r/22131/#comment79011>

    is this change and the ones below it, are they really required?


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Ivan Lyutov <iv...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
-----------------------------------------------------------

(Updated June 2, 2014, 2:32 p.m.)


Review request for kafka.


Bugs: KAFKA-1477
    https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
-------

Reverted gradle version


Added SSL for Kafka

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.


Diffs (updated)
-----

  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
  core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
  core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
  core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
  core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
  core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
  core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
  gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
-------


Thanks,

Ivan Lyutov

Re: Review Request 22131: Patch for KAFKA-1477

Posted by Ivan Lyutov <iv...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
-----------------------------------------------------------

(Updated June 2, 2014, 2:07 p.m.)


Review request for kafka.


Bugs: KAFKA-1477
    https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
-------

Added SSL for Kafka

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.


Diffs (updated)
-----

  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 
  core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d 
  core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a 
  core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION 
  core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 
  core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
  core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
  gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
-------


Thanks,

Ivan Lyutov