You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Anshum Gupta (JIRA)" <ji...@apache.org> on 2014/09/10 09:18:29 UTC
[jira] [Commented] (SOLR-6496) LBHttpSolrServer should stop server
retries after the timeAllowed threshold is met
[ https://issues.apache.org/jira/browse/SOLR-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128168#comment-14128168 ]
Anshum Gupta commented on SOLR-6496:
------------------------------------
Thanks for creating this JIRA and providing a patch [~sdavids].
Here are a few changes that I'd recommend:
* Use System.nanoTime() for calculating elapsed time. SOLR-5734 was recently an attempt at standardizing the same.
* Tests are always helpful for confirming that the change works as expected :). I'm personally against mocking unless there's no other way out as it generally has led to code that is difficult to understand for newer developers when they want to change something.
> LBHttpSolrServer should stop server retries after the timeAllowed threshold is met
> ----------------------------------------------------------------------------------
>
> Key: SOLR-6496
> URL: https://issues.apache.org/jira/browse/SOLR-6496
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.9
> Reporter: Steve Davids
> Priority: Critical
> Fix For: 4.11
>
> Attachments: SOLR-6496.patch, SOLR-6496.patch
>
>
> The LBHttpSolrServer will continue to perform retries for each server it was given without honoring the timeAllowed request parameter. Once the threshold has been met, you should no longer perform retries and allow the exception to bubble up and allow the request to either error out or return partial results per the shards.tolerant request parameter.
> For a little more context on how this is can be extremely problematic please see the comment here: https://issues.apache.org/jira/browse/SOLR-5986?focusedCommentId=14100991&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14100991 (#2)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org