[GitHub] [kafka] iblislin commented on pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()

[GitBox <gi...@apache.org>]

iblislin commented on PR #12371:
URL: https://github.com/apache/kafka/pull/12371#issuecomment-1370578419

   Hi,
   
   I still ran into the issue of NPE on a 3.3.1 cluster with 3 nodes.
   
   The actual line throwing the NPE is here: https://github.com/apache/kafka/blob/3.3.1/metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java#L125
   
   But I cannot speak in Java, no idea about the root cause.
   
   The traceback:
   ```
   kafka-k3-1  | [2023-01-04 06:23:20,276] ERROR Encountered fatal fault: exception while renouncing leadership (org.apache.kafka.server.fault.ProcessExitingFaultHandler)
   kafka-k3-1  | java.lang.NullPointerException
   kafka-k3-1  |   at org.apache.kafka.timeline.SnapshottableHashTable$HashTier.mergeFrom(SnapshottableHashTable.java:125)
   kafka-k3-1  |   at org.apache.kafka.timeline.Snapshot.mergeFrom(Snapshot.java:68)
   kafka-k3-1  |   at org.apache.kafka.timeline.SnapshotRegistry.deleteSnapshot(SnapshotRegistry.java:236)
   kafka-k3-1  |   at org.apache.kafka.timeline.SnapshotRegistry$SnapshotIterator.remove(SnapshotRegistry.java:67)
   kafka-k3-1  |   at org.apache.kafka.timeline.SnapshotRegistry.revertToSnapshot(SnapshotRegistry.java:214)
   kafka-k3-1  |   at org.apache.kafka.controller.QuorumController.renounce(QuorumController.java:1232)
   kafka-k3-1  |   at org.apache.kafka.controller.QuorumController.access$3300(QuorumController.java:150)
   kafka-k3-1  |   at org.apache.kafka.controller.QuorumController$QuorumMetaLogListener.lambda$handleLeaderChange$3(QuorumController.java:1076)
   kafka-k3-1  |   at org.apache.kafka.controller.QuorumController$QuorumMetaLogListener.lambda$appendRaftEvent$4(QuorumController.java:1101)
   kafka-k3-1  |   at org.apache.kafka.controller.QuorumController$ControlEvent.run(QuorumController.java:496)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org