You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2021/09/14 06:38:12 UTC
Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73584/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
Bugs: ATLAS-4422
https://issues.apache.org/jira/browse/ATLAS-4422
Repository: atlas
Description
-------
**Improvement:**
This will add a sorting functionality in quick search API and get the result list in Sorted manner.
**Note:**
- Result will be sorted only when 'typeName' has a valid entity type name as a value.
- Only string attribute type (not TEXT) guarantees sorted results
**Example:**
{ "query":"sales",
"typeName":"Asset",
"sortBy":"__typeName",
"sortOrder":"ASCENDING" }
Diffs
-----
intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.java 9e5e9778a
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5b3b9486b
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e4c74a9d1
Diff: https://reviews.apache.org/r/73584/diff/1/
Testing
-------
Tested manually
Thanks,
Pinal Shah
Re: Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73584/#review223491
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Sept. 15, 2021, 4:03 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73584/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2021, 4:03 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4422
> https://issues.apache.org/jira/browse/ATLAS-4422
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Improvement:**
>
> This will add a sorting functionality in quick search API and get the result list in Sorted manner.
>
> **Note:**
>
> - Result will be sorted only when 'typeName' has a valid entity type name as a value.
> - Only string attribute type (not TEXT) guarantees sorted results
>
> **Example:**
>
> { "query":"sales",
> "typeName":"Asset",
> "sortBy":"__typeName",
> "sortOrder":"ASCENDING" }
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.java 9e5e9778a
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5b3b9486b
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 5e47295cb
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e4c74a9d1
>
>
> Diff: https://reviews.apache.org/r/73584/diff/2/
>
>
> Testing
> -------
>
> added Unit tests
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73584/#review223492
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Sept. 15, 2021, 9:03 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73584/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2021, 9:03 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4422
> https://issues.apache.org/jira/browse/ATLAS-4422
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Improvement:**
>
> This will add a sorting functionality in quick search API and get the result list in Sorted manner.
>
> **Note:**
>
> - Result will be sorted only when 'typeName' has a valid entity type name as a value.
> - Only string attribute type (not TEXT) guarantees sorted results
>
> **Example:**
>
> { "query":"sales",
> "typeName":"Asset",
> "sortBy":"__typeName",
> "sortOrder":"ASCENDING" }
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.java 9e5e9778a
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5b3b9486b
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 5e47295cb
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e4c74a9d1
>
>
> Diff: https://reviews.apache.org/r/73584/diff/2/
>
>
> Testing
> -------
>
> added Unit tests
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73584/
-----------------------------------------------------------
(Updated Sept. 15, 2021, 4:03 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
Changes
-------
added UTs
Bugs: ATLAS-4422
https://issues.apache.org/jira/browse/ATLAS-4422
Repository: atlas
Description
-------
**Improvement:**
This will add a sorting functionality in quick search API and get the result list in Sorted manner.
**Note:**
- Result will be sorted only when 'typeName' has a valid entity type name as a value.
- Only string attribute type (not TEXT) guarantees sorted results
**Example:**
{ "query":"sales",
"typeName":"Asset",
"sortBy":"__typeName",
"sortOrder":"ASCENDING" }
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.java 9e5e9778a
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5b3b9486b
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 5e47295cb
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e4c74a9d1
Diff: https://reviews.apache.org/r/73584/diff/2/
Changes: https://reviews.apache.org/r/73584/diff/1-2/
Testing (updated)
-------
added Unit tests
Thanks,
Pinal Shah
Re: Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73584/#review223486
-----------------------------------------------------------
Ship it!
lgtm. Can you include UT/IT tests around this sorting.
- Sarath Subramanian
On Sept. 13, 2021, 11:38 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73584/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2021, 11:38 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4422
> https://issues.apache.org/jira/browse/ATLAS-4422
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Improvement:**
>
> This will add a sorting functionality in quick search API and get the result list in Sorted manner.
>
> **Note:**
>
> - Result will be sorted only when 'typeName' has a valid entity type name as a value.
> - Only string attribute type (not TEXT) guarantees sorted results
>
> **Example:**
>
> { "query":"sales",
> "typeName":"Asset",
> "sortBy":"__typeName",
> "sortOrder":"ASCENDING" }
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.java 9e5e9778a
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5b3b9486b
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e4c74a9d1
>
>
> Diff: https://reviews.apache.org/r/73584/diff/1/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting
Posted by radhe son <so...@gmail.com>.
On 2021/09/14 06:38:12, Pinal Shah <pi...@freestoneinfotech.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73584/
> -----------------------------------------------------------
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4422
> https://issues.apache.org/jira/browse/ATLAS-4422
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Improvement:**
>
> This will add a sorting functionality in quick search API and get the result list in Sorted manner.
>
> **Note:**
>
> - Result will be sorted only when 'typeName' has a valid entity type name as a value.
> - Only string attribute type (not TEXT) guarantees sorted results
>
> **Example:**
>
> { "query":"sales",
> "typeName":"Asset",
> "sortBy":"__typeName",
> "sortOrder":"ASCENDING" }
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.java 9e5e9778a
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5b3b9486b
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e4c74a9d1
>
>
> Diff: https://reviews.apache.org/r/73584/diff/1/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Pinal Shah
>
>
<a href="http://customerfeedbacks.site/talktomcalisters/">TalktoMCAlisters.com</a>