You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2023/12/20 20:32:00 UTC
[jira] [Comment Edited] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799166#comment-17799166 ]
Ekaterina Dimitrova edited comment on CASSANDRA-18688 at 12/20/23 8:31 PM:
---------------------------------------------------------------------------
{quote}this quickly becomes a rabbit hole, what about "enabled" or "yes", and case-sensitivity…
{quote}
{quote}why I'm ok with it just being set to anything (even false). It might not be ideal, but intuitive enough that users will figure it out quickly…
{quote}
For me, as a user, this is confusing and non-deterministic, prone to typos, etc; that is why I was fine with -J.
Setting it to false and being able to run it with whatever JDK sounds...at least weird.
Anyway, then we should at least change the error message from
{code:java}
echo "If you would like to test with newer Java versions set CASSANDRA_JDK_UNSUPPORTED=true"{code}
to
{code:java}
echo "If you would like to test with newer Java versions set CASSANDRA_JDK_UNSUPPORTED to anything"{code}
was (Author: e.dimitrova):
{quote}this quickly becomes a rabbit hole, what about "enabled" or "yes", and case-sensitivity…
{quote}
{quote}why I'm ok with it just being set to anything (even false). It might not be ideal, but intuitive enough that users will figure it out quickly…
{quote}
For me, as a user, this is confusing and non-deterministic, prone to typos, etc; that is why I was fine with -J.
Setting it to false and being able to run it with whatever JDK sounds...at least weird.
> Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18688
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: shylaja kokoori
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently, we limit our users from building with non-default Java versions in build.xml.
> They can easily hack build.xml for test purposes with different versions.
> Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit people to those two, but only to everything >= 11. We should also put an upper limit of 17 in our Cassandra startup scripts. We can also add a flag to opt-out if someone wants to test with newer versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org