You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/09/13 22:04:04 UTC
[GitHub] [commons-pool] psteitz opened a new pull request #43: Add DestroyMode to provide context to destroyObject activations. Fixe…
psteitz opened a new pull request #43:
URL: https://github.com/apache/commons-pool/pull/43
…s POOL-387, needed by DBCP-567.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-pool] garydgregory commented on pull request #43: Add DestroyMode to provide context to destroyObject activations. Fixe…
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #43:
URL: https://github.com/apache/commons-pool/pull/43#issuecomment-691775229
@psteitz
LGTM & TY. I will merge in the AM with fresh eyes. The only item I will modify after a merge, or you can do here, it is to add Javadoc `since` tags for all new public methods, and since we have new APIs, the `since` will be for 2.9.0 instead of 2.8.2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-pool] garydgregory merged pull request #43: Add DestroyMode to provide context to destroyObject activations. Fixe…
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #43:
URL: https://github.com/apache/commons-pool/pull/43
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-pool] coveralls commented on pull request #43: Add DestroyMode to provide context to destroyObject activations. Fixe…
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #43:
URL: https://github.com/apache/commons-pool/pull/43#issuecomment-691733225
[](https://coveralls.io/builds/33425308)
Coverage decreased (-0.2%) to 84.257% when pulling **e2b1a8132ce59a9d6e6b4310f80ca81fb2a4b595 on psteitz:master** into **2360671b114894d91b61c893a3299e61d033d946 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org