[GitHub] [dolphinscheduler] dailidong commented on a change in pull request #7082: [Feature][dolphinscheduler-api] access control of taskDefinition and taskInstance in project to #7081

[GitBox <gi...@apache.org>]

dailidong commented on a change in pull request #7082:
URL: https://github.com/apache/dolphinscheduler/pull/7082#discussion_r759457964



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskInstanceServiceImpl.java
##########
@@ -171,6 +176,12 @@ public Result queryTaskListPaging(User loginUser,
             return result;
         }
 
+        TaskDefinition taskDefinition = taskDefinitionMapper.queryByCode(task.getTaskCode());
+        if (taskDefinition != null && projectCode != taskDefinition.getProjectCode()) {
+            putMsg(result, Status.TASK_INSTANCE_NOT_FOUND, taskInstanceId);

Review comment:
       is the message prompt ` Status.TASK_INSTANCE_NOT_FOUND` right?  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org