You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Prabhjyot Singh <pr...@gmail.com> on 2017/02/13 17:13:23 UTC
Review Request 56604: Zeppelin UI to support proxy access via Knox in
Ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
Bugs: AMBARI-19988
https://issues.apache.org/jira/browse/AMBARI-19988
Repository: ambari
Description
-------
Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
Diffs
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
Diff: https://reviews.apache.org/r/56604/diff/
Testing
-------
Manually tested on CentOS
Thanks,
Prabhjyot Singh
Re: Review Request 56604: Zeppelin UI to support proxy access via
Knox in Ambari
Posted by Prabhjyot Singh <pr...@gmail.com>.
> On Feb. 21, 2017, 5:21 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml, line 69
> > <https://reviews.apache.org/r/56604/diff/1/?file=1632091#file1632091line69>
> >
> > Is this really meant to be added on an Ambari upgrade?
Yes, this block wouldn't cause any problem, and if zeppelin is not installed this will be set to the default value which is false.
Wouldn't cause any harm.
- Prabhjyot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review166188
-----------------------------------------------------------
On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
>
> Diff: https://reviews.apache.org/r/56604/diff/
>
>
> Testing
> -------
>
> Manually tested on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56604: Zeppelin UI to support proxy access via
Knox in Ambari
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review166188
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml (line 69)
<https://reviews.apache.org/r/56604/#comment238064>
Is this really meant to be added on an Ambari upgrade?
- Alejandro Fernandez
On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
>
> Diff: https://reviews.apache.org/r/56604/diff/
>
>
> Testing
> -------
>
> Manually tested on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56604: Zeppelin UI to support proxy access via
Knox in Ambari
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review166051
-----------------------------------------------------------
Ship it!
Ship It!
- Renjith Kamath
On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
>
> Diff: https://reviews.apache.org/r/56604/diff/
>
>
> Testing
> -------
>
> Manually tested on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56604: Zeppelin UI to support proxy access via
Knox in Ambari
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review166052
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
>
> Diff: https://reviews.apache.org/r/56604/diff/
>
>
> Testing
> -------
>
> Manually tested on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56604: Zeppelin UI to support proxy access via
Knox in Ambari
Posted by Prabhjyot Singh <pr...@gmail.com>.
> On Feb. 13, 2017, 6:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml, line 146
> > <https://reviews.apache.org/r/56604/diff/1/?file=1632093#file1632093line146>
> >
> > What should the behavior be during a stack upgrade, say from HDP 2.5 to 2.6?
> >
> > Should this config be changed only if the user hasn't modified it from its original value, or should it be forcibly changed to this new value?
>
> Prabhjyot Singh wrote:
> Should I add "<on-ambari-upgrade add="true"/>" here as well ? I thought line:172 had it, hence not required.
Also, this feature was not there in HDP-2.5, so IMO upgrade wont apply for this.
- Prabhjyot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review165363
-----------------------------------------------------------
On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
>
> Diff: https://reviews.apache.org/r/56604/diff/
>
>
> Testing
> -------
>
> Manually tested on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56604: Zeppelin UI to support proxy access via
Knox in Ambari
Posted by Prabhjyot Singh <pr...@gmail.com>.
> On Feb. 13, 2017, 6:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml, line 146
> > <https://reviews.apache.org/r/56604/diff/1/?file=1632093#file1632093line146>
> >
> > What should the behavior be during a stack upgrade, say from HDP 2.5 to 2.6?
> >
> > Should this config be changed only if the user hasn't modified it from its original value, or should it be forcibly changed to this new value?
Should I add "<on-ambari-upgrade add="true"/>" here as well ? I thought line:172 had it, hence not required.
- Prabhjyot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review165363
-----------------------------------------------------------
On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
>
> Diff: https://reviews.apache.org/r/56604/diff/
>
>
> Testing
> -------
>
> Manually tested on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56604: Zeppelin UI to support proxy access via
Knox in Ambari
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review165363
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml (line 146)
<https://reviews.apache.org/r/56604/#comment237198>
What should the behavior be during a stack upgrade, say from HDP 2.5 to 2.6?
Should this config be changed only if the user hasn't modified it from its original value, or should it be forcibly changed to this new value?
- Alejandro Fernandez
On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
>
> Diff: https://reviews.apache.org/r/56604/diff/
>
>
> Testing
> -------
>
> Manually tested on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56604: Zeppelin UI to support proxy access via
Knox in Ambari
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review166055
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Zeppelin UI to support proxy access via Knox should get configured with Ambari out-of-the-box.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml 3837019
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py febede3
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml 6862e4d
>
> Diff: https://reviews.apache.org/r/56604/diff/
>
>
> Testing
> -------
>
> Manually tested on CentOS
>
>
> Thanks,
>
> Prabhjyot Singh
>
>