You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Howard Lewis Ship <hl...@gmail.com> on 2014/04/02 00:40:54 UTC
WTF with the broken tests?
Please stop committing broken changes!
It is extremely disrespectful to the other developers and their very full
schedules to commit code that is broken. Ok, it's very disrespectful to me
and my 150% over-taxed schedule.
I've spent the last couple of hours fixing other people's bugs in the test
suites.
I'm trying to generate a beta-4 release.
Any idea what this is about?
:tapestry-ioc-test:test
org.apache.tapestry5.ioc.test.TapestryIOCJUnit4ClassRunnerAfterClassTest >
testInjectB FAILED
java.lang.AssertionError at
TapestryIOCJUnit4ClassRunnerAfterClassTest.java:51
5 tests completed, 1 failed
:tapestry-ioc-test:test FAILED
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
Re: WTF with the broken tests?
Posted by Thiago H de Paula Figueiredo <th...@gmail.com>.
On Wed, 02 Apr 2014 13:50:13 -0300, Howard Lewis Ship <hl...@gmail.com>
wrote:
> Everyone's checked in code thinking it would work, I do so myself on
> occasion (*). But it seems like it's becoming more habitual, with code
> checked in that couldn't possibly pass its tests.
My theory is this is a byproduct of people who aren't up to speed with
actually committing Tapestry code yet.
--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: WTF with the broken tests?
Posted by Bob Harner <bo...@gmail.com>.
It would also be a big help if the automated builds could be made to
work again, so broken builds are noted immediately instead of days or
weeks later. Last I heard Uli was working on setting up a new server?
On Wed, Apr 2, 2014 at 12:50 PM, Howard Lewis Ship <hl...@gmail.com> wrote:
> Thanks!
>
> It's just that you aren't the only one.
>
> Everyone's checked in code thinking it would work, I do so myself on
> occasion (*). But it seems like it's becoming more habitual, with code
> checked in that couldn't possibly pass its tests.
>
>
> (*) Although I run the tapestry-core tests very consistently before
> pushing, I've gotten stung by an innocuous change in tapestry-core that
> broke something in one of the dependent libraries. I also got screwed
> recently by IntelliJ reformatting my CoffeeScript code at check in ...
> wrong.
>
>
> On Tue, Apr 1, 2014 at 11:13 PM, Lance Java <la...@googlemail.com>wrote:
>
>> So sorry... I can appreciate that you're overstretched.
>> I've removed :tapestry-ioc-test from the build so that the build can pass
>> again
>> I'll fix the test tonight (UK time).
>>
>>
>> On 1 April 2014 23:40, Howard Lewis Ship <hl...@gmail.com> wrote:
>>
>> > Please stop committing broken changes!
>> >
>> > It is extremely disrespectful to the other developers and their very full
>> > schedules to commit code that is broken. Ok, it's very disrespectful to
>> me
>> > and my 150% over-taxed schedule.
>> >
>> > I've spent the last couple of hours fixing other people's bugs in the
>> test
>> > suites.
>> >
>> > I'm trying to generate a beta-4 release.
>> >
>> > Any idea what this is about?
>> >
>> > :tapestry-ioc-test:test
>> >
>> > org.apache.tapestry5.ioc.test.TapestryIOCJUnit4ClassRunnerAfterClassTest
>> >
>> > testInjectB FAILED
>> > java.lang.AssertionError at
>> > TapestryIOCJUnit4ClassRunnerAfterClassTest.java:51
>> >
>> > 5 tests completed, 1 failed
>> > :tapestry-ioc-test:test FAILED
>> >
>> > --
>> > Howard M. Lewis Ship
>> >
>> > Creator of Apache Tapestry
>> >
>> > The source for Tapestry training, mentoring and support. Contact me to
>> > learn how I can get you up and productive in Tapestry fast!
>> >
>> > (971) 678-5210
>> > http://howardlewisship.com
>> >
>>
>
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: WTF with the broken tests?
Posted by Howard Lewis Ship <hl...@gmail.com>.
Thanks!
It's just that you aren't the only one.
Everyone's checked in code thinking it would work, I do so myself on
occasion (*). But it seems like it's becoming more habitual, with code
checked in that couldn't possibly pass its tests.
(*) Although I run the tapestry-core tests very consistently before
pushing, I've gotten stung by an innocuous change in tapestry-core that
broke something in one of the dependent libraries. I also got screwed
recently by IntelliJ reformatting my CoffeeScript code at check in ...
wrong.
On Tue, Apr 1, 2014 at 11:13 PM, Lance Java <la...@googlemail.com>wrote:
> So sorry... I can appreciate that you're overstretched.
> I've removed :tapestry-ioc-test from the build so that the build can pass
> again
> I'll fix the test tonight (UK time).
>
>
> On 1 April 2014 23:40, Howard Lewis Ship <hl...@gmail.com> wrote:
>
> > Please stop committing broken changes!
> >
> > It is extremely disrespectful to the other developers and their very full
> > schedules to commit code that is broken. Ok, it's very disrespectful to
> me
> > and my 150% over-taxed schedule.
> >
> > I've spent the last couple of hours fixing other people's bugs in the
> test
> > suites.
> >
> > I'm trying to generate a beta-4 release.
> >
> > Any idea what this is about?
> >
> > :tapestry-ioc-test:test
> >
> > org.apache.tapestry5.ioc.test.TapestryIOCJUnit4ClassRunnerAfterClassTest
> >
> > testInjectB FAILED
> > java.lang.AssertionError at
> > TapestryIOCJUnit4ClassRunnerAfterClassTest.java:51
> >
> > 5 tests completed, 1 failed
> > :tapestry-ioc-test:test FAILED
> >
> > --
> > Howard M. Lewis Ship
> >
> > Creator of Apache Tapestry
> >
> > The source for Tapestry training, mentoring and support. Contact me to
> > learn how I can get you up and productive in Tapestry fast!
> >
> > (971) 678-5210
> > http://howardlewisship.com
> >
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
Re: WTF with the broken tests?
Posted by Lance Java <la...@googlemail.com>.
So sorry... I can appreciate that you're overstretched.
I've removed :tapestry-ioc-test from the build so that the build can pass
again
I'll fix the test tonight (UK time).
On 1 April 2014 23:40, Howard Lewis Ship <hl...@gmail.com> wrote:
> Please stop committing broken changes!
>
> It is extremely disrespectful to the other developers and their very full
> schedules to commit code that is broken. Ok, it's very disrespectful to me
> and my 150% over-taxed schedule.
>
> I've spent the last couple of hours fixing other people's bugs in the test
> suites.
>
> I'm trying to generate a beta-4 release.
>
> Any idea what this is about?
>
> :tapestry-ioc-test:test
>
> org.apache.tapestry5.ioc.test.TapestryIOCJUnit4ClassRunnerAfterClassTest >
> testInjectB FAILED
> java.lang.AssertionError at
> TapestryIOCJUnit4ClassRunnerAfterClassTest.java:51
>
> 5 tests completed, 1 failed
> :tapestry-ioc-test:test FAILED
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>