You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/01/20 15:16:01 UTC
Review Request 55770: Fixed navbar and logo size in WebUI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55770/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6963
https://issues.apache.org/jira/browse/MESOS-6963
Repository: mesos
Description
-------
Prevented the logo from stretching the navbar height making it
consistent with mobile version.
http://getbootstrap.com/components/#navbar-brand-image
Diffs
-----
src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
Diff: https://reviews.apache.org/r/55770/diff/
Testing
-------
Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
Thanks,
Ilya Pronin
Re: Review Request 55770: Fixed navbar and logo size in WebUI.
Posted by Ilya Pronin <ip...@twopensource.com>.
> On Jan. 20, 2017, 3:18 p.m., haosdent huang wrote:
> > src/webui/master/static/index.html, line 33
> > <https://reviews.apache.org/r/55770/diff/1/?file=1610638#file1610638line33>
> >
> > How about add class `.img-responsive` directly?
>
> Ilya Pronin wrote:
> I tried, that didn't work :(
>
> haosdent huang wrote:
> Oh, just realize the height value of `.navbar-header` is not match other places. May you fix this by
>
> ```
> diff --git a/src/webui/master/static/css/mesos.css b/src/webui/master/static/css/mesos.css
> index 5077d45d8..75fc9d875 100644
> --- a/src/webui/master/static/css/mesos.css
> +++ b/src/webui/master/static/css/mesos.css
> @@ -11,6 +11,10 @@
> color: #FFF;
> }
>
> +.navbar .navbar-header {
> + height: 60px;
> +}
> +
> .navbar .navbar-nav > li > a {
> color: inherit;
> padding-top: 20px;
> ```
>
> It fixes this problem as well.
>
> haosdent huang wrote:
> Should be
>
> ```
> .navbar .navbar-header,
> .navbar .navbar-brand {
> height: 60px;
> }
> ```
Dropping the issue as discussed on Slack.
- Ilya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55770/#review162428
-----------------------------------------------------------
On Jan. 20, 2017, 3:16 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55770/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6963
> https://issues.apache.org/jira/browse/MESOS-6963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prevented the logo from stretching the navbar height making it
> consistent with mobile version.
> http://getbootstrap.com/components/#navbar-brand-image
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/55770/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55770: Fixed navbar and logo size in WebUI.
Posted by haosdent huang <ha...@apache.org>.
> On Jan. 20, 2017, 3:18 p.m., haosdent huang wrote:
> > src/webui/master/static/index.html, line 33
> > <https://reviews.apache.org/r/55770/diff/1/?file=1610638#file1610638line33>
> >
> > How about add class `.img-responsive` directly?
>
> Ilya Pronin wrote:
> I tried, that didn't work :(
>
> haosdent huang wrote:
> Oh, just realize the height value of `.navbar-header` is not match other places. May you fix this by
>
> ```
> diff --git a/src/webui/master/static/css/mesos.css b/src/webui/master/static/css/mesos.css
> index 5077d45d8..75fc9d875 100644
> --- a/src/webui/master/static/css/mesos.css
> +++ b/src/webui/master/static/css/mesos.css
> @@ -11,6 +11,10 @@
> color: #FFF;
> }
>
> +.navbar .navbar-header {
> + height: 60px;
> +}
> +
> .navbar .navbar-nav > li > a {
> color: inherit;
> padding-top: 20px;
> ```
>
> It fixes this problem as well.
Should be
```
.navbar .navbar-header,
.navbar .navbar-brand {
height: 60px;
}
```
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55770/#review162428
-----------------------------------------------------------
On Jan. 20, 2017, 3:16 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55770/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6963
> https://issues.apache.org/jira/browse/MESOS-6963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prevented the logo from stretching the navbar height making it
> consistent with mobile version.
> http://getbootstrap.com/components/#navbar-brand-image
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/55770/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55770: Fixed navbar and logo size in WebUI.
Posted by Ilya Pronin <ip...@twopensource.com>.
> On Jan. 20, 2017, 3:18 p.m., haosdent huang wrote:
> > src/webui/master/static/index.html, line 33
> > <https://reviews.apache.org/r/55770/diff/1/?file=1610638#file1610638line33>
> >
> > How about add class `.img-responsive` directly?
I tried, that didn't work :(
- Ilya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55770/#review162428
-----------------------------------------------------------
On Jan. 20, 2017, 3:16 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55770/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6963
> https://issues.apache.org/jira/browse/MESOS-6963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prevented the logo from stretching the navbar height making it
> consistent with mobile version.
> http://getbootstrap.com/components/#navbar-brand-image
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/55770/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55770: Fixed navbar and logo size in WebUI.
Posted by haosdent huang <ha...@apache.org>.
> On Jan. 20, 2017, 3:18 p.m., haosdent huang wrote:
> > src/webui/master/static/index.html, line 33
> > <https://reviews.apache.org/r/55770/diff/1/?file=1610638#file1610638line33>
> >
> > How about add class `.img-responsive` directly?
>
> Ilya Pronin wrote:
> I tried, that didn't work :(
Oh, just realize the height value of `.navbar-header` is not match other places. May you fix this by
```
diff --git a/src/webui/master/static/css/mesos.css b/src/webui/master/static/css/mesos.css
index 5077d45d8..75fc9d875 100644
--- a/src/webui/master/static/css/mesos.css
+++ b/src/webui/master/static/css/mesos.css
@@ -11,6 +11,10 @@
color: #FFF;
}
+.navbar .navbar-header {
+ height: 60px;
+}
+
.navbar .navbar-nav > li > a {
color: inherit;
padding-top: 20px;
```
It fixes this problem as well.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55770/#review162428
-----------------------------------------------------------
On Jan. 20, 2017, 3:16 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55770/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6963
> https://issues.apache.org/jira/browse/MESOS-6963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prevented the logo from stretching the navbar height making it
> consistent with mobile version.
> http://getbootstrap.com/components/#navbar-brand-image
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/55770/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55770: Fixed navbar and logo size in WebUI.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55770/#review162428
-----------------------------------------------------------
src/webui/master/static/index.html (line 33)
<https://reviews.apache.org/r/55770/#comment233755>
How about add class `.img-responsive` directly?
- haosdent huang
On Jan. 20, 2017, 3:16 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55770/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6963
> https://issues.apache.org/jira/browse/MESOS-6963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prevented the logo from stretching the navbar height making it
> consistent with mobile version.
> http://getbootstrap.com/components/#navbar-brand-image
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/55770/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55770: Fixed navbar and logo size in WebUI.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55770/#review162645
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Jan. 20, 2017, 3:16 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55770/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6963
> https://issues.apache.org/jira/browse/MESOS-6963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prevented the logo from stretching the navbar height making it
> consistent with mobile version.
> http://getbootstrap.com/components/#navbar-brand-image
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/55770/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55770: Fixed navbar and logo size in WebUI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55770/#review162523
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55770]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 20, 2017, 3:16 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55770/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6963
> https://issues.apache.org/jira/browse/MESOS-6963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prevented the logo from stretching the navbar height making it
> consistent with mobile version.
> http://getbootstrap.com/components/#navbar-brand-image
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/55770/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>