You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Haisheng Yuan (Jira)" <ji...@apache.org> on 2020/01/29 19:40:00 UTC

[jira] [Resolved] (CALCITE-3756) RelSubset should not match operand(RelNode.class)

     [ https://issues.apache.org/jira/browse/CALCITE-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haisheng Yuan resolved CALCITE-3756.
------------------------------------
    Fix Version/s: 1.22.0
       Resolution: Fixed

Fixed in https://github.com/apache/calcite/commit/0b97f45752f111b56aa499b037077d27db82ec47.

> RelSubset should not match operand(RelNode.class)
> -------------------------------------------------
>
>                 Key: CALCITE-3756
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3756
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Even RelSubset is a subclass of RelNode, but they are quite different. RelNode already fires these rules, it is not necessary to fire for RelSubset. More importantly, it never worked due to CALCITE-3755.
> In addition, it will waste time to try to iterate class operands of RelSubset and try to match pattern operand(RelNode), given that it never matches when ascending.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)