You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by as...@apache.org on 2022/01/31 08:58:39 UTC

[camel-k] 28/40: Flag tekton test as problematic

This is an automated email from the ASF dual-hosted git repository.

astefanutti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git

commit 958064d7854cb8712fa9644a24cc67a2c8a7f51a
Author: phantomjinx <p....@phantomjinx.co.uk>
AuthorDate: Fri Jan 14 14:27:48 2022 +0000

    Flag tekton test as problematic
    
    * Tries to install kamel using the camel-operator service
      account, which on OCP4 makes use of the OLM. This SA does
      not have the permissions for the OLM so the test needs to
      use a different SA - don't want to extend the operator's
      permissions.
---
 e2e/common/tekton_test.go | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/e2e/common/tekton_test.go b/e2e/common/tekton_test.go
index 2ceb1c4..7b893c5 100644
--- a/e2e/common/tekton_test.go
+++ b/e2e/common/tekton_test.go
@@ -23,6 +23,7 @@ limitations under the License.
 package common
 
 import (
+	"os"
 	"testing"
 
 	. "github.com/onsi/gomega"
@@ -32,7 +33,23 @@ import (
 
 // TestTektonLikeBehavior verifies that the kamel binary can be invoked from within the Camel K image.
 // This feature is used in Tekton pipelines.
+
+/*
+ * TODO
+ * Test has issues on OCP4.
+ * Since that cluster installs via OLM, permissions are required for the
+ * service account doing the install to access the OLM, eg. get:subscriptions.
+ *
+ * Need to change the service account used to execute this test as do not
+ * want to extend the permissions of the operator service account
+ *
+ * Adding CAMEL_K_TEST_SKIP_PROBLEMATIC env var for the moment.
+ */
 func TestTektonLikeBehavior(t *testing.T) {
+	if os.Getenv("CAMEL_K_TEST_SKIP_PROBLEMATIC") == "true" {
+		t.Skip("WARNING: Test marked as problematic ... skipping")
+	}
+
 	WithNewTestNamespace(t, func(ns string) {
 		Expect(CreateOperatorServiceAccount(ns)).To(Succeed())
 		Expect(CreateOperatorRole(ns)).To(Succeed())