You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org> on 2012/11/22 23:54:58 UTC
[jira] [Created] (SQOOP-722) Improve Sqoop 2 packaging
Jarek Jarcec Cecho created SQOOP-722:
----------------------------------------
Summary: Improve Sqoop 2 packaging
Key: SQOOP-722
URL: https://issues.apache.org/jira/browse/SQOOP-722
Project: Sqoop
Issue Type: Improvement
Affects Versions: 2.0.0
Reporter: Jarek Jarcec Cecho
Assignee: Jarek Jarcec Cecho
Fix For: 2.0.0
I would like to propose two improvements to current building (dist module):
* Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
* Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-722) Improve Sqoop 2 packaging
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated SQOOP-722:
-------------------------------------
Attachment: bugSQOOP-722.patch
> Improve Sqoop 2 packaging
> -------------------------
>
> Key: SQOOP-722
> URL: https://issues.apache.org/jira/browse/SQOOP-722
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 2.0.0
>
> Attachments: bugSQOOP-722.patch
>
>
> I would like to propose two improvements to current building (dist module):
> * Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
> * Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-722) Improve Sqoop 2 packaging
Posted by "Abhijeet Gaikwad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506588#comment-13506588 ]
Abhijeet Gaikwad commented on SQOOP-722:
----------------------------------------
Thanks for clarifying Jarcec.
On your first suggestion, I feel packaging source and binaries are two independent tasks and should not be merged into one.
-1.
Thanks.
> Improve Sqoop 2 packaging
> -------------------------
>
> Key: SQOOP-722
> URL: https://issues.apache.org/jira/browse/SQOOP-722
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 2.0.0
>
> Attachments: bugSQOOP-722.patch
>
>
> I would like to propose two improvements to current building (dist module):
> * Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
> * Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-722) Improve Sqoop 2 packaging
Posted by "Abhijeet Gaikwad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510215#comment-13510215 ]
Abhijeet Gaikwad commented on SQOOP-722:
----------------------------------------
Thanks Jarcec.
The patch looks good to me.
> Improve Sqoop 2 packaging
> -------------------------
>
> Key: SQOOP-722
> URL: https://issues.apache.org/jira/browse/SQOOP-722
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 2.0.0
>
> Attachments: bugSQOOP-722.patch, bugSQOOP-722.patch
>
>
> I would like to propose two improvements to current building (dist module):
> * Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
> * Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-722) Improve Sqoop 2 packaging
Posted by "Abhijeet Gaikwad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503255#comment-13503255 ]
Abhijeet Gaikwad commented on SQOOP-722:
----------------------------------------
Second suggestion is a go ahead.
For the first, I feel source and binary packages should be different. When a user wants to pack only source, binary is an unnecessary attachment. Similarly, when a user or more specifically RM creates a binary package, source will be packed per hadoop profile - which doesn't just seem right, provided source is hadoop profile independent. Let me know your views. If my understanding is correct, its a -1.
> Improve Sqoop 2 packaging
> -------------------------
>
> Key: SQOOP-722
> URL: https://issues.apache.org/jira/browse/SQOOP-722
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 2.0.0
>
> Attachments: bugSQOOP-722.patch
>
>
> I would like to propose two improvements to current building (dist module):
> * Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
> * Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-722) Improve Sqoop 2 packaging
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509424#comment-13509424 ]
Jarek Jarcec Cecho commented on SQOOP-722:
------------------------------------------
I've removed first proposed suggestion from the patch per Abhijeet's -1.
> Improve Sqoop 2 packaging
> -------------------------
>
> Key: SQOOP-722
> URL: https://issues.apache.org/jira/browse/SQOOP-722
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 2.0.0
>
> Attachments: bugSQOOP-722.patch, bugSQOOP-722.patch
>
>
> I would like to propose two improvements to current building (dist module):
> * Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
> * Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-722) Improve Sqoop 2 packaging
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503261#comment-13503261 ]
Jarek Jarcec Cecho commented on SQOOP-722:
------------------------------------------
Hi Abhijeet,
thank you very much for your feedback, I appreciate your time.
Regarding your concern on first suggestion. I believe that we quite did not understand each other, so let me describe the suggestion little bit more. Right now user had to call maven twice to build source and binary artifacts. With this patch he need to call maven only once. However even thought we still build two separate artifacts. This suggestion is only about building both artifacts during single maven call. Consider following list with created artifacts:
* mvn package -Dhadoop.profile=200
** sqoop-2.0.0-SNAPSHOT.tar.gz (source)
** sqoop-2.0.0-SNAPSHOT-bin-hadoop200.tar.gz (binary)
* mvn package -Dhadoop.profile=100
** sqoop-2.0.0-SNAPSHOT.tar.gz (source)
** sqoop-2.0.0-SNAPSHOT-bin-hadoop100.tar.gz (binary)
The source artifacts are exactly the same in both profiles as they are independent on Hadoop version. They just happen to be created each time. Does this help clear your concern?
> Improve Sqoop 2 packaging
> -------------------------
>
> Key: SQOOP-722
> URL: https://issues.apache.org/jira/browse/SQOOP-722
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 2.0.0
>
> Attachments: bugSQOOP-722.patch
>
>
> I would like to propose two improvements to current building (dist module):
> * Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
> * Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-722) Improve Sqoop 2 packaging
Posted by "Bilung Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510232#comment-13510232 ]
Bilung Lee commented on SQOOP-722:
----------------------------------
Thanks Jarcec's contribution and Abhijeet's review. The patch is committed now.
> Improve Sqoop 2 packaging
> -------------------------
>
> Key: SQOOP-722
> URL: https://issues.apache.org/jira/browse/SQOOP-722
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 2.0.0
>
> Attachments: bugSQOOP-722.patch, bugSQOOP-722.patch
>
>
> I would like to propose two improvements to current building (dist module):
> * Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
> * Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-722) Improve Sqoop 2 packaging
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated SQOOP-722:
-------------------------------------
Attachment: bugSQOOP-722.patch
> Improve Sqoop 2 packaging
> -------------------------
>
> Key: SQOOP-722
> URL: https://issues.apache.org/jira/browse/SQOOP-722
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 2.0.0
>
> Attachments: bugSQOOP-722.patch, bugSQOOP-722.patch
>
>
> I would like to propose two improvements to current building (dist module):
> * Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
> * Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira