You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2009/06/10 16:14:39 UTC
DO NOT REPLY [Bug 47347] New: [PATCH] auto table layout - yet
another patch
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
Summary: [PATCH] auto table layout - yet another patch
Product: Fop
Version: 1.0dev
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: page-master/layout
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: achim.derigs@innovidata.com
Depends on: 40271
Hi,
this is yet another patch to enable auto table layout. I've done some work for
one of our customers who needs auto table layout. This patch is doing the job.
I've tried several ways to minimize side effects (and implementation efforts)
as much as possible. Now it hardly affects the existing process.
May be there are cases which are not considered currently. It's certainly an
improvable approach.
Best Regards
Achim
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
Peterdk <ap...@umito.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |apache.bugzilla@umito.nl
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
--- Comment #3 from Peterdk <ap...@umito.nl> 2010-03-23 19:21:53 UTC ---
I tried the patch.
It doesn't work with current trunk revision, but it does (of course) work with
the revision specified in the diff (783305). Not really a problem.
It works great for simple tables. Main problem I have with the patch is that it
doesn't work when the block that contains the table, or the table itself has a
margin-left set. It falls back to the original FOP behaviour, which is
unwanted.
That's quite a problem, since you can't layout any table on the page this way.
I hope this can be easily adjusted, but since this patch is almost a year old,
I am afraid it won't happen. Will try to look into it myself, but the codebase
is too advanced for me to really grasp.
I do have some money to spend as a bounty for getting it to work however.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
Glenn Adams <ga...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
--- Comment #6 from Glenn Adams <ga...@apache.org> 2012-04-11 03:22:13 UTC ---
increase priority for bugs with a patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
carsten.pfeiffer@gebit.de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |carsten.pfeiffer@gebit.de
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
--- Comment #5 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:42:05 UTC ---
resetting P2 open bugs to P3 pending further review
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
--- Comment #4 from Peterdk <ap...@umito.nl> 2010-03-26 13:05:31 UTC ---
In case anyone needs to use this auto layout table with a margin-left set on
containing block:
Use a 2 column table. Set first column-width to the required left-margin. Fill
the second column with the table that you want auto-layouted. This way the
auto-layout still works and you have a left margin.
So, this will do for me.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P3
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
--- Comment #1 from Achim Derigs <ac...@innovidata.com> 2009-06-10 07:21:24 PST ---
Created an attachment (id=23787)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23787)
auto-table-layout.diff
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
Jens Bannmann <je...@web.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jens.b@web.de
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 47347] [PATCH] auto table layout - yet another
patch
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47347
--- Comment #2 from Vincent Hennebert <vh...@gmail.com> 2009-06-11 03:54:03 PST ---
Hi Achim,
(In reply to comment #0)
> Hi,
>
> this is yet another patch to enable auto table layout. I've done some work for
> one of our customers who needs auto table layout. This patch is doing the job.
>
> I've tried several ways to minimize side effects (and implementation efforts)
> as much as possible. Now it hardly affects the existing process.
>
> May be there are cases which are not considered currently. It's certainly an
> improvable approach.
>
> Best Regards
> Achim
Thank you very much for your patch. It may prove useful to other users who need
this feature to work on simple tables.
We are not going to apply it to the Trunk, though, as it only cover very simple
cases. For example, it doesn't handle the case of a cell consisting of a long
paragraph that must be broken into lines. Also it doesn't seem to do well with
nested tables.
Still, like I said above some users with only simple cases may be interested in
applying this patch to their local copy.
I hope you understand.
Thanks,
Vincent
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.