You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "lokiore (via GitHub)" <gi...@apache.org> on 2023/09/06 22:57:00 UTC

[GitHub] [phoenix] lokiore opened a new pull request, #1670: PHOENIX-6979 (Addendum) Use HBase TTL as TTL for Tables only at Phoenix Level when phoenix.table.ttl.enabled is true

lokiore opened a new pull request, #1670:
URL: https://github.com/apache/phoenix/pull/1670

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] jpisaac commented on pull request #1670: PHOENIX-6979 (Addendum) Use HBase TTL as TTL for Tables only at Phoenix Level when phoenix.table.ttl.enabled is true

Posted by "jpisaac (via GitHub)" <gi...@apache.org>.
jpisaac commented on PR #1670:
URL: https://github.com/apache/phoenix/pull/1670#issuecomment-1717917224

   Looks good.
   @lokiore Need to handle the case for TTL=FOREVER.
   Previously NONE was supported, but we should support it going forward. Since HBase TTL spec does not allow it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] jpisaac commented on pull request #1670: PHOENIX-6979 (Addendum) Use HBase TTL as TTL for Tables only at Phoenix Level when phoenix.table.ttl.enabled is true

Posted by "jpisaac (via GitHub)" <gi...@apache.org>.
jpisaac commented on PR #1670:
URL: https://github.com/apache/phoenix/pull/1670#issuecomment-1720022700

   LGTM +1 Thanks @lokiore 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] virajjasani merged pull request #1670: PHOENIX-6979 (Addendum) Use HBase TTL as TTL for Tables only at Phoenix Level when phoenix.table.ttl.enabled is true

Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani merged PR #1670:
URL: https://github.com/apache/phoenix/pull/1670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] lokiore commented on pull request #1670: PHOENIX-6979 (Addendum) Use HBase TTL as TTL for Tables only at Phoenix Level when phoenix.table.ttl.enabled is true

Posted by "lokiore (via GitHub)" <gi...@apache.org>.
lokiore commented on PR #1670:
URL: https://github.com/apache/phoenix/pull/1670#issuecomment-1710520758

   Not Sure why this is not showing build but all tests passed :- https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1670/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
   @jpisaac 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] lokiore commented on pull request #1670: PHOENIX-6979 (Addendum) Use HBase TTL as TTL for Tables only at Phoenix Level when phoenix.table.ttl.enabled is true

Posted by "lokiore (via GitHub)" <gi...@apache.org>.
lokiore commented on PR #1670:
URL: https://github.com/apache/phoenix/pull/1670#issuecomment-1718333706

   > Looks good. @lokiore Need to handle the case for TTL=FOREVER. Previously NONE was supported, but we should support it going forward. Since HBase TTL spec does not allow it.
   
   @jpisaac I have updated the PR to handle FOREVER and NONE value in both cases, when phoenix.table.level.ttl is enabled or disabled. Will create a JIRA to remove NONE value from TTL as it will require other changes as well and out of scope of this JIRA. Thanks!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org