You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/11 15:39:34 UTC
[GitHub] [nifi] marcocharlie opened a new pull request, #6293: [NIFI-10349] Add maximum object age property to list s3
marcocharlie opened a new pull request, #6293:
URL: https://github.com/apache/nifi/pull/6293
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
I needed to add the maximum object age property in ListS3 as minimum object age property is already available.
Signed-off-by: Marco [marco.carlino@pagopa.it](mailto:marco.carlino@pagopa.it)
[NIFI-10349](https://issues.apache.org/jira/browse/NIFI-10349)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] marcocharlie commented on pull request #6293: [NIFI-10349] Add maximum object age property to list s3
Posted by GitBox <gi...@apache.org>.
marcocharlie commented on PR #6293:
URL: https://github.com/apache/nifi/pull/6293#issuecomment-1250989769
@MikeThomsen how does it work to go on with the PR? cc @mronci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #6293: [NIFI-10349] Add maximum object age property to list s3
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on PR #6293:
URL: https://github.com/apache/nifi/pull/6293#issuecomment-1305645204
Merging to main...
@MikeThomsen Feel free to open a follow-up jira if you have any further comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] marcocharlie commented on a diff in pull request #6293: [NIFI-10349] Add maximum object age property to list s3
Posted by GitBox <gi...@apache.org>.
marcocharlie commented on code in PR #6293:
URL: https://github.com/apache/nifi/pull/6293#discussion_r962924894
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##########
@@ -217,6 +217,14 @@ public class ListS3 extends AbstractS3Processor implements VerifiableProcessor {
.defaultValue("0 sec")
.build();
+ public static final PropertyDescriptor MAX_AGE = new Builder()
Review Comment:
thank you very much we added `createMaxAgeValidator` and fixed `testListIgnoreByMaxAge`, ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a diff in pull request #6293: [NIFI-10349] Add maximum object age property to list s3
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on code in PR #6293:
URL: https://github.com/apache/nifi/pull/6293#discussion_r962162164
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##########
@@ -217,6 +217,14 @@ public class ListS3 extends AbstractS3Processor implements VerifiableProcessor {
.defaultValue("0 sec")
.build();
+ public static final PropertyDescriptor MAX_AGE = new Builder()
Review Comment:
You need an additional validation in `customValidate` to ensure the MAX_AGE is greater than the MIN_AGE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] marcocharlie commented on pull request #6293: [NIFI-10349] Add maximum object age property to list s3
Posted by GitBox <gi...@apache.org>.
marcocharlie commented on PR #6293:
URL: https://github.com/apache/nifi/pull/6293#issuecomment-1289025283
Hi @MikeThomsen, how can we merge this PR to main branch? Have we missed something? cc @mronci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6293: [NIFI-10349] Add maximum object age property to list s3
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on code in PR #6293:
URL: https://github.com/apache/nifi/pull/6293#discussion_r1003404736
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##########
@@ -217,6 +218,15 @@ public class ListS3 extends AbstractS3Processor implements VerifiableProcessor {
.defaultValue("0 sec")
.build();
+ public static final PropertyDescriptor MAX_AGE = new Builder()
+ .name("max-age")
+ .displayName("Maximum Object Age")
+ .description("The maximum age that an S3 object must be in order to be considered; any object older than this amount of time (according to last modification date) will be ignored")
Review Comment:
@marcocharlie I had a look at the code and I think there is a typo here:
```suggestion
.description("The maximum age that an S3 object can be in order to be considered; any object older than this amount of time (according to last modification date) will be ignored")
```
or `may be in order to be considered`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] marcocharlie commented on pull request #6293: [NIFI-10349] Add maximum object age property to list s3
Posted by GitBox <gi...@apache.org>.
marcocharlie commented on PR #6293:
URL: https://github.com/apache/nifi/pull/6293#issuecomment-1290106997
thank you @turcsanyip!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6293: [NIFI-10349] Add maximum object age property to list s3
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6293: [NIFI-10349] Add maximum object age property to list s3
URL: https://github.com/apache/nifi/pull/6293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org