[jira] [Commented] (SPARK-14525) DataFrameWriter's save method should delegate to jdbc for jdbc datasource

["Justin Pihony (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366259#comment-15366259 ] 

Justin Pihony commented on SPARK-14525:
---------------------------------------

[~rxin] Given the bug found in SPARK-16401, the CreatableRelationProvider is not necessary. However it might be nice to have now that I've already implemented it. I can reduce the code by removing the CreatableRelationProvider aspect, so I would love your feedback on my PR. 

> DataFrameWriter's save method should delegate to jdbc for jdbc datasource
> -------------------------------------------------------------------------
>
>                 Key: SPARK-14525
>                 URL: https://issues.apache.org/jira/browse/SPARK-14525
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 1.6.1
>            Reporter: Justin Pihony
>            Priority: Minor
>
> If you call {code}df.write.format("jdbc")...save(){code} then you get an error  
> bq. org.apache.spark.sql.execution.datasources.jdbc.DefaultSource does not allow create table as select
> save is a more intuitive guess on the appropriate method to call, so the user should not be punished for not knowing about the jdbc method. 
> Obviously, this will require the caller to have set up the correct parameters for jdbc to work :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org