You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2006/01/27 21:49:57 UTC

Status of patch?

This patch

http://svn.apache.org/viewcvs.cgi/apr/apr/trunk/file_io/win32/readwrite.c?rev=314856&view=markup

backporting this patch

http://svn.apache.org/viewcvs.cgi?view=rev&rev=76283

to fix apr_vformatter on win32 is a little unclear to me; it's missing
all the credits in the 'backport' and both were missing CHANGES?

Re: Status of patch?

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 1/27/06, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> This patch
>
> http://svn.apache.org/viewcvs.cgi/apr/apr/trunk/file_io/win32/readwrite.c?rev=314856&view=markup
>
> backporting this patch
>
> http://svn.apache.org/viewcvs.cgi?view=rev&rev=76283
>
> to fix apr_vformatter on win32 is a little unclear to me; it's missing
> all the credits in the 'backport' and both were missing CHANGES?

Well, it's really more of a "sideport", since it's just going from the
unix code to the win32 code in the same version, and as for credits,
it did refer to the intial commit, which credited the contributors.

As for CHANGES entries, they could probably stand to have one, but the
committer of the initial change didn't add one and nobody complained
about it, so I didn't add one when I backported the changes to 1.2.x
and 0.9.x.

-garrett