You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/24 11:22:44 UTC
[GitHub] [hadoop-ozone] runzhiwang opened a new pull request #1122: HDDS-3861. Fix handlePipelineFailure throw exception if role is follower
runzhiwang opened a new pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122
## What changes were proposed in this pull request?
1. if role is follower, ozone will throw exception.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3861
## How was this patch tested?
Existed tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1122: HDDS-3861. Fix handlePipelineFailure throw exception if role is follower
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122#issuecomment-648761379
@bshashikant Could you help review this patch ? Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #1122: HDDS-3861. Fix handlePipelineFailure throw exception if role is follower
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122#discussion_r445689746
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -552,6 +552,10 @@ private void handlePipelineFailure(RaftGroupId groupId,
msg = datanode + " is in candidate state for " +
roleInfoProto.getCandidateInfo().getLastLeaderElapsedTimeMs() + "ms";
break;
+ case FOLLOWER:
+ msg = datanode + " is in follower state for " +
Review comment:
Can we update the msg accordingly with the reason. The reason precisely was when installSnapshotFromLeader gets invoked on follower, as leader snapshot doesn't contain any data to replay. All the log entries prior to the snapshot might have been purged. So , follower should not try to install snapshot from leader but can close the pipeline here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1122: HDDS-3861. Fix handlePipelineFailure throw exception if role is follower
Posted by GitBox <gi...@apache.org>.
runzhiwang edited a comment on pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122#issuecomment-657909810
@adoroszlai Could you help merge it ? The comment is just about the message of reason, I have updated it, I think it does not matter. But if without this PR, the cluster is very unstable. Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1122: HDDS-3861. Fix handlePipelineFailure throw exception if role is follower
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122#issuecomment-657909810
@adoroszlai Could you help merge it ? The comment is just about the message of reason, I have updated it, I think it does not matter. But if without this PR, the cluster is very unstable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runzhiwang commented on a change in pull request #1122: HDDS-3861. Fix handlePipelineFailure throw exception if role is follower
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on a change in pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122#discussion_r445935211
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -552,6 +552,10 @@ private void handlePipelineFailure(RaftGroupId groupId,
msg = datanode + " is in candidate state for " +
roleInfoProto.getCandidateInfo().getLastLeaderElapsedTimeMs() + "ms";
break;
+ case FOLLOWER:
+ msg = datanode + " is in follower state for " +
Review comment:
@bshashikant Thanks for you review and explanation. I have updated the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant merged pull request #1122: HDDS-3861. Fix handlePipelineFailure throw exception if role is follower
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org