You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 07:13:48 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request, #17538: [improve][cpp] Upgrade OpenSSL to version 1.1.1n
RobertIndie opened a new pull request, #17538:
URL: https://github.com/apache/pulsar/pull/17538
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Currently, there exists two different OpenSSL version in the repo: 1.1.1n and 1.1.0j. This PR upgrades all these OpenSSL dependencies to 1.1.1n.
### Modifications
* Upgrade OpenSSL to version 1.1.1n
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17538: [improve][cpp] Upgrade OpenSSL to version 1.1.1n
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17538:
URL: https://github.com/apache/pulsar/pull/17538#issuecomment-1244898721
@RobertIndie Please fix this issue:
Building debian packages fails in https://github.com/apache/pulsar/actions/runs/3019434098/jobs/4855451903#step:8:29495
```
../lib/.libs/libcurl.so: undefined reference to `SSL_CTX_set_keylog_callback@OPENSSL_1_1_1'
../lib/.libs/libcurl.so: undefined reference to `SSL_CTX_set_ciphersuites@OPENSSL_1_1_1'
collect2: error: ld returned 1 exit status
make[2]: *** [curl] Error 1
Makefile:839: recipe for target 'curl' failed
make[2]: Leaving directory '/curl-7.61.0/src'
make[1]: *** [all-recursive] Error 1
Makefile:1878: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/curl-7.61.0/src'
Makefile:927: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
```
That slipped into master since the CI wasn't preventing merging of builds with failing checks temporarily and this PR wasn't rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #17538: [improve][cpp] Upgrade OpenSSL to version 1.1.1n
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #17538:
URL: https://github.com/apache/pulsar/pull/17538#issuecomment-1249020461
We should cherry-pick #17614 as well because it's a fix on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #17538: [improve][cpp] Upgrade OpenSSL to version 1.1.1n
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17538:
URL: https://github.com/apache/pulsar/pull/17538#issuecomment-1243163739
@RobertIndie Please check CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #17538: [improve][cpp] Upgrade OpenSSL to version 1.1.1n
Posted by GitBox <gi...@apache.org>.
merlimat merged PR #17538:
URL: https://github.com/apache/pulsar/pull/17538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #17538: [improve][cpp] Upgrade OpenSSL to version 1.1.1n
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #17538:
URL: https://github.com/apache/pulsar/pull/17538#issuecomment-1245115045
FYI, I will handle this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #17538: [improve][cpp] Upgrade OpenSSL to version 1.1.1n
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17538:
URL: https://github.com/apache/pulsar/pull/17538#issuecomment-1249012747
@RobertIndie Can you help cherry-pick this to branch-2.10? There are some conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org