You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by nemon lou <lo...@huawei.com> on 2012/05/03 12:57:29 UTC
Review Request: import tool for mysql direct mode reports wrong record number
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Summary
-------
I simply change the way the MySQLDumpMapper writes contents.
May be there are other ways to fix it.Please let me know,thank you!
This addresses bug SQOOP-482.
https://issues.apache.org/jira/browse/SQOOP-482
Diffs
-----
./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889
Diff: https://reviews.apache.org/r/4988/diff
Testing
-------
Thanks,
nemon
Re: Review Request: import tool for mysql direct mode reports wrong record
number
Posted by nemon lou <lo...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/#review7500
-----------------------------------------------------------
- nemon
On 2012-05-03 10:57:29, nemon lou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4988/
> -----------------------------------------------------------
>
> (Updated 2012-05-03 10:57:29)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Summary
> -------
>
> I simply change the way the MySQLDumpMapper writes contents.
> May be there are other ways to fix it.Please let me know,thank you!
>
>
> This addresses bug SQOOP-482.
> https://issues.apache.org/jira/browse/SQOOP-482
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889
>
> Diff: https://reviews.apache.org/r/4988/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> nemon
>
>
Re: Review Request: import tool for mysql direct mode reports wrong record
number
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/#review7581
-----------------------------------------------------------
Ship it!
+1
Nemon, thanks for the patch. Noticed that the timestamp of the patch uploaded to the jira is 5/3 but on review board the last diff was made on 5/4. Nemon, would you mind uploading the latest patch to the jira as SQOOP-482-1.patch?
- Kathleen
On 2012-05-04 07:33:48, nemon lou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4988/
> -----------------------------------------------------------
>
> (Updated 2012-05-04 07:33:48)
>
>
> Review request for Sqoop, Jarek Cecho and Cheolsoo Park.
>
>
> Summary
> -------
>
> I simply change the way the MySQLDumpMapper writes contents.
> May be there are other ways to fix it.Please let me know,thank you!
>
>
> This addresses bug SQOOP-482.
> https://issues.apache.org/jira/browse/SQOOP-482
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889
>
> Diff: https://reviews.apache.org/r/4988/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> nemon
>
>
Re: Review Request: import tool for mysql direct mode reports wrong record
number
Posted by Cheolsoo Park <ch...@cloudera.com>.
> On 2012-05-04 18:36:37, Cheolsoo Park wrote:
> > Nemon's fix seems to be right to me. The write() method should be called only once per record. I also verified that his patch addresses the problem.
> >
> > @Nemon
> > I am no commiter, so I cannot commit your patch. But you've got my vote!
@Kate
To be clear, I am not disagreeing with you. I am just talking about Nemon's diff file on reviewboard, and the patch on the jire has to be uploaded.
Hope that nobody misinterprets my comment. :-)
- Cheolsoo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/#review7580
-----------------------------------------------------------
On 2012-05-04 07:33:48, nemon lou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4988/
> -----------------------------------------------------------
>
> (Updated 2012-05-04 07:33:48)
>
>
> Review request for Sqoop, Jarek Cecho and Cheolsoo Park.
>
>
> Summary
> -------
>
> I simply change the way the MySQLDumpMapper writes contents.
> May be there are other ways to fix it.Please let me know,thank you!
>
>
> This addresses bug SQOOP-482.
> https://issues.apache.org/jira/browse/SQOOP-482
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889
>
> Diff: https://reviews.apache.org/r/4988/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> nemon
>
>
Re: Review Request: import tool for mysql direct mode reports wrong record
number
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/#review7580
-----------------------------------------------------------
Ship it!
Nemon's fix seems to be right to me. The write() method should be called only once per record. I also verified that his patch addresses the problem.
@Nemon
I am no commiter, so I cannot commit your patch. But you've got my vote!
- Cheolsoo
On 2012-05-04 07:33:48, nemon lou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4988/
> -----------------------------------------------------------
>
> (Updated 2012-05-04 07:33:48)
>
>
> Review request for Sqoop, Jarek Cecho and Cheolsoo Park.
>
>
> Summary
> -------
>
> I simply change the way the MySQLDumpMapper writes contents.
> May be there are other ways to fix it.Please let me know,thank you!
>
>
> This addresses bug SQOOP-482.
> https://issues.apache.org/jira/browse/SQOOP-482
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889
>
> Diff: https://reviews.apache.org/r/4988/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> nemon
>
>
Re: Review Request: import tool for mysql direct mode reports wrong record
number
Posted by nemon lou <lo...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/
-----------------------------------------------------------
(Updated 2012-05-04 07:33:48.277299)
Review request for Sqoop, Jarek Cecho and Cheolsoo Park.
Changes
-------
checkstyle fixed
Summary
-------
I simply change the way the MySQLDumpMapper writes contents.
May be there are other ways to fix it.Please let me know,thank you!
This addresses bug SQOOP-482.
https://issues.apache.org/jira/browse/SQOOP-482
Diffs (updated)
-----
./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889
Diff: https://reviews.apache.org/r/4988/diff
Testing
-------
Thanks,
nemon
Re: Review Request: import tool for mysql direct mode reports wrong record
number
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/#review7546
-----------------------------------------------------------
Thank you very much for your patch. It looks good, but there are two minor coding convention issues. If you run "ant checkstyle", you will see the following errors that I commented inline. Would you mind fixing them and updating the patch?
./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java
<https://reviews.apache.org/r/4988/#comment16716>
This line is longer than 80 chars.
./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java
<https://reviews.apache.org/r/4988/#comment16715>
Please remove a tab char here.
- Cheolsoo
On 2012-05-04 01:02:58, nemon lou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4988/
> -----------------------------------------------------------
>
> (Updated 2012-05-04 01:02:58)
>
>
> Review request for Sqoop, Jarek Cecho and Cheolsoo Park.
>
>
> Summary
> -------
>
> I simply change the way the MySQLDumpMapper writes contents.
> May be there are other ways to fix it.Please let me know,thank you!
>
>
> This addresses bug SQOOP-482.
> https://issues.apache.org/jira/browse/SQOOP-482
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889
>
> Diff: https://reviews.apache.org/r/4988/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> nemon
>
>
Re: Review Request: import tool for mysql direct mode reports wrong record
number
Posted by nemon lou <lo...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/
-----------------------------------------------------------
(Updated 2012-05-04 01:02:58.521635)
Review request for Sqoop, Jarek Cecho and Cheolsoo Park.
Changes
-------
Add more review people!
Summary
-------
I simply change the way the MySQLDumpMapper writes contents.
May be there are other ways to fix it.Please let me know,thank you!
This addresses bug SQOOP-482.
https://issues.apache.org/jira/browse/SQOOP-482
Diffs
-----
./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889
Diff: https://reviews.apache.org/r/4988/diff
Testing
-------
Thanks,
nemon