You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/06/21 21:48:14 UTC

[GitHub] dewrich commented on a change in pull request #2451: Fix delivery service validation

dewrich commented on a change in pull request #2451: Fix delivery service validation
URL: https://github.com/apache/trafficcontrol/pull/2451#discussion_r197287797
 
 

 ##########
 File path: lib/go-tc/tovalidate/rules.go
 ##########
 @@ -46,3 +48,19 @@ func IsOneOfStringICase(set ...string) func(string) bool {
 	}
 	return IsOneOfString(lowcased...)
 }
+
+func IsGreaterThanZero(value interface{}) error {
 
 Review comment:
   This function could be refactored to here: https://github.com/apache/trafficcontrol/blob/master/lib/go-tc/tovalidate/rules.go#L19

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services