[GitHub] [spark] cloud-fan commented on a diff in pull request #42633: [SPARK-44846][SQL] Convert the distinct-like Aggregate to Project

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42633:
URL: https://github.com/apache/spark/pull/42633#discussion_r1303943447


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregatesSuite.scala:
##########
@@ -52,6 +52,7 @@ class RemoveRedundantAggregatesSuite extends PlanTest {
         .groupBy($"a")($"a")
         .analyze
       val expected = relation
+        .select($"a")

Review Comment:
   to avoid making many changes in this suite, can we add the rule `RemoveNoopOperators` to the test Batch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org