You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 09:40:18 UTC
[GitHub] [flink] pnowojski opened a new pull request #12020: [hotfix][network] Do not cache InputChannels in UnionInputGate
pnowojski opened a new pull request #12020:
URL: https://github.com/apache/flink/pull/12020
This is a simple fix for a bug on the master branch that is not visible currently in anyway, but which is causing an inconsistent state with `UnionInputGate` if underlying channels are changing.
## Verifying this change
This change added a new unit test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12020: [FLINK-17552][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12020:
URL: https://github.com/apache/flink/pull/12020#issuecomment-625150189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"triggerType" : "PUSH"
}, {
"hash" : "4203b2dffa8493394a8f9c3dc5723801b15dd163",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4203b2dffa8493394a8f9c3dc5723801b15dd163",
"triggerType" : "PUSH"
}, {
"hash" : "6dad1301491a163324578ea1c3ae3a98355888b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=743",
"triggerID" : "6dad1301491a163324578ea1c3ae3a98355888b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a007cc30e7b8afd3aa199331088c60ff80dae45 UNKNOWN
* 4203b2dffa8493394a8f9c3dc5723801b15dd163 UNKNOWN
* 6dad1301491a163324578ea1c3ae3a98355888b6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=743)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12020: [FLINK-17552][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12020:
URL: https://github.com/apache/flink/pull/12020#issuecomment-625150189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"triggerType" : "PUSH"
}, {
"hash" : "4203b2dffa8493394a8f9c3dc5723801b15dd163",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4203b2dffa8493394a8f9c3dc5723801b15dd163",
"triggerType" : "PUSH"
}, {
"hash" : "6dad1301491a163324578ea1c3ae3a98355888b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=743",
"triggerID" : "6dad1301491a163324578ea1c3ae3a98355888b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a007cc30e7b8afd3aa199331088c60ff80dae45 UNKNOWN
* 4203b2dffa8493394a8f9c3dc5723801b15dd163 UNKNOWN
* 6dad1301491a163324578ea1c3ae3a98355888b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=743)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12020: [FLINK-17552][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12020:
URL: https://github.com/apache/flink/pull/12020#issuecomment-625150189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"triggerType" : "PUSH"
}, {
"hash" : "4203b2dffa8493394a8f9c3dc5723801b15dd163",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4203b2dffa8493394a8f9c3dc5723801b15dd163",
"triggerType" : "PUSH"
}, {
"hash" : "6dad1301491a163324578ea1c3ae3a98355888b6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6dad1301491a163324578ea1c3ae3a98355888b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a007cc30e7b8afd3aa199331088c60ff80dae45 UNKNOWN
* 4203b2dffa8493394a8f9c3dc5723801b15dd163 UNKNOWN
* 6dad1301491a163324578ea1c3ae3a98355888b6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12020: [FLINK-17552][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12020:
URL: https://github.com/apache/flink/pull/12020#issuecomment-625150189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"triggerType" : "PUSH"
}, {
"hash" : "4203b2dffa8493394a8f9c3dc5723801b15dd163",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4203b2dffa8493394a8f9c3dc5723801b15dd163",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a007cc30e7b8afd3aa199331088c60ff80dae45 UNKNOWN
* 4203b2dffa8493394a8f9c3dc5723801b15dd163 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12020: [hotfix][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12020:
URL: https://github.com/apache/flink/pull/12020#issuecomment-625148230
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 70088254d856c0b18e664e5e05105b536502ac3d (Thu May 07 09:45:34 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #12020: [FLINK-17552][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #12020:
URL: https://github.com/apache/flink/pull/12020#discussion_r421389847
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
##########
@@ -101,14 +99,19 @@ public UnionInputGate(IndexedInputGate... inputGates) {
final int maxGateIndex = Arrays.stream(inputGates).mapToInt(IndexedInputGate::getGateIndex).max().orElse(0);
inputGateChannelIndexOffsets = new int[maxGateIndex + 1];
+ int totalNumberOfInputChannels = 0;
Review comment:
`total = Arrays.stream(inputGates).mapToInt(IndexedInputGate::getNumberOfInputChannels).sum()` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #12020: [FLINK-17552][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #12020:
URL: https://github.com/apache/flink/pull/12020#discussion_r421439531
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImpl.java
##########
@@ -19,6 +19,8 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.runtime.checkpoint.CheckpointOptions;
+import org.apache.flink.runtime.event.AbstractEvent;
Review comment:
nit: Add `ChannelStateWriterImpl` to commit msg.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12020: [hotfix][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12020:
URL: https://github.com/apache/flink/pull/12020#issuecomment-625150189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a007cc30e7b8afd3aa199331088c60ff80dae45",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a007cc30e7b8afd3aa199331088c60ff80dae45 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #12020: [FLINK-17552][network] Do not cache InputChannels in UnionInputGate
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #12020:
URL: https://github.com/apache/flink/pull/12020#issuecomment-625259857
Thanks for the review @AHeise. Test failures are unrelated (unable to download a dependency and https://issues.apache.org/jira/browse/FLINK-17416). Merging with changed commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org