You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/11 05:43:46 UTC
[GitHub] [skywalking] mrproliu opened a new pull request #6363: Change the Apdex metric combine calculator
mrproliu opened a new pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363
### Update the Apdex metric combine calculator
- Follow the [Apdex document in The New Relic](https://docs.newrelic.com/docs/apm/new-relic-apm/apdex/apdex-measure-user-satisfaction), I think we need to change the range between Apdex levels.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `9.55%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 56.47% +9.55%
- Complexity 3438 3954 +516
============================================
Files 976 977 +1
Lines 24159 24282 +123
Branches 2378 2386 +8
============================================
+ Hits 11337 13714 +2377
+ Misses 11870 9367 -2503
- Partials 952 1201 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.63% <0.00%> (-56.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==) | `48.88% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `54.26% <0.00%> (+0.89%)` | `12.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.39% <0.00%> (+0.98%)` | `19.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `85.91% <0.00%> (+1.40%)` | `21.00% <0.00%> (+1.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.49% <0.00%> (+1.68%)` | `6.00% <0.00%> (ø%)` | |
| ... and [142 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `9.71%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 56.63% +9.71%
- Complexity 3438 3958 +520
============================================
Files 976 977 +1
Lines 24159 24282 +123
Branches 2378 2386 +8
============================================
+ Hits 11337 13753 +2416
+ Misses 11870 9320 -2550
- Partials 952 1209 +257
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==) | `48.88% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `54.26% <0.00%> (+0.89%)` | `12.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.39% <0.00%> (+0.98%)` | `19.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `85.91% <0.00%> (+1.40%)` | `21.00% <0.00%> (+1.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.49% <0.00%> (+1.68%)` | `6.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <0.00%> (+2.56%)` | `9.00% <0.00%> (+1.00%)` | |
| [.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==) | `55.88% <0.00%> (+2.94%)` | `7.00% <0.00%> (ø%)` | |
| ... and [140 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.38%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 53.31% +6.38%
- Complexity 3438 3737 +299
============================================
Files 976 977 +1
Lines 24159 24216 +57
Branches 2378 2363 -15
============================================
+ Hits 11337 12910 +1573
+ Misses 11870 10149 -1721
- Partials 952 1157 +205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [171 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.04%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 52.97% +6.04%
- Complexity 3438 3725 +287
============================================
Files 976 977 +1
Lines 24159 24216 +57
Branches 2378 2363 -15
============================================
+ Hits 11337 12828 +1491
+ Misses 11870 10248 -1622
- Partials 952 1140 +188
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [173 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.22%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 53.15% +6.22%
- Complexity 3438 3733 +295
============================================
Files 976 977 +1
Lines 24159 24216 +57
Branches 2378 2363 -15
============================================
+ Hits 11337 12871 +1534
+ Misses 11870 10196 -1674
- Partials 952 1149 +197
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [173 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.69%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 53.61% +6.69%
- Complexity 3438 3984 +546
============================================
Files 976 1767 +791
Lines 24159 37669 +13510
Branches 2378 4177 +1799
============================================
+ Hits 11337 20197 +8860
- Misses 11870 16475 +4605
- Partials 952 997 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `100.00% <100.00%> (+5.88%)` | `6.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `30.23% <0.00%> (-62.63%)` | `3.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `17.85% <0.00%> (-37.70%)` | `2.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7InsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdJbnNlcnRSZXF1ZXN0LmphdmE=) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `60.00% <0.00%> (-15.00%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...server/core/analysis/worker/AlarmNotifyWorker.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL0FsYXJtTm90aWZ5V29ya2VyLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `3.00% <0.00%> (ø%)` | |
| ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 49.03% +2.10%
- Complexity 3438 3535 +97
============================================
Files 976 977 +1
Lines 24159 24209 +50
Branches 2378 2366 -12
============================================
+ Hits 11337 11871 +534
+ Misses 11870 11326 -544
- Partials 952 1012 +60
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <0.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-95.46%)` | `0.00% <0.00%> (-17.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [129 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `5.32%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 41.60% -5.33%
+ Complexity 3438 3049 -389
============================================
Files 976 959 -17
Lines 24159 23634 -525
Branches 2378 2309 -69
============================================
- Hits 11337 9832 -1505
- Misses 11870 12952 +1082
+ Partials 952 850 -102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `82.35% <0.00%> (-11.77%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [183 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `6.30%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 40.61% -6.31%
+ Complexity 3438 2448 -990
============================================
Files 976 826 -150
Lines 24159 20409 -3750
Branches 2378 1926 -452
============================================
- Hits 11337 8290 -3047
+ Misses 11870 11477 -393
+ Partials 952 642 -310
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <50.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.62%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 53.55% +6.62%
- Complexity 3438 3782 +344
============================================
Files 976 976
Lines 24159 24224 +65
Branches 2378 2382 +4
============================================
+ Hits 11337 12973 +1636
+ Misses 11870 10118 -1752
- Partials 952 1133 +181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/event/listener/EventRecordAnalyzerListener.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L2xpc3RlbmVyL0V2ZW50UmVjb3JkQW5hbHl6ZXJMaXN0ZW5lci5qYXZh) | `18.51% <0.00%> (-62.97%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [134 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `8.35%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 55.28% +8.35%
- Complexity 3438 3895 +457
============================================
Files 976 977 +1
Lines 24159 24269 +110
Branches 2378 2386 +8
============================================
+ Hits 11337 13416 +2079
+ Misses 11870 9672 -2198
- Partials 952 1181 +229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/event/listener/EventRecordAnalyzerListener.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L2xpc3RlbmVyL0V2ZW50UmVjb3JkQW5hbHl6ZXJMaXN0ZW5lci5qYXZh) | `18.51% <0.00%> (-62.97%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.63% <0.00%> (-56.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyRXZlbnRRdWVyeURBTy5qYXZh) | `1.58% <0.00%> (-46.04%)` | `1.00% <0.00%> (-3.00%)` | |
| [...apache/skywalking/oap/server/core/event/Event.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvZXZlbnQvRXZlbnQuamF2YQ==) | `1.33% <0.00%> (-22.67%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ing/oap/server/telemetry/api/HistogramMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hpc3RvZ3JhbU1ldHJpY3MuamF2YQ==) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
| ... and [140 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `4.09%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 42.83% -4.10%
+ Complexity 3438 3112 -326
============================================
Files 976 959 -17
Lines 24159 23651 -508
Branches 2378 2309 -69
============================================
- Hits 11337 10131 -1206
- Misses 11870 12644 +774
+ Partials 952 876 -76
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <0.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `0.17%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 47.10% +0.17%
+ Complexity 3438 2807 -631
============================================
Files 976 826 -150
Lines 24159 20588 -3571
Branches 2378 1974 -404
============================================
- Hits 11337 9697 -1640
+ Misses 11870 10124 -1746
+ Partials 952 767 -185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [273 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `2.60%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 44.32% -2.61%
+ Complexity 3438 2694 -744
============================================
Files 976 826 -150
Lines 24159 20563 -3596
Branches 2378 1958 -420
============================================
- Hits 11337 9114 -2223
+ Misses 11870 10723 -1147
+ Partials 952 726 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <0.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [285 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `10.39%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
=============================================
+ Coverage 46.92% 57.31% +10.39%
- Complexity 3438 3984 +546
=============================================
Files 976 977 +1
Lines 24159 24282 +123
Branches 2378 2386 +8
=============================================
+ Hits 11337 13918 +2581
+ Misses 11870 9147 -2723
- Partials 952 1217 +265
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==) | `48.88% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `54.26% <0.00%> (+0.89%)` | `12.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.39% <0.00%> (+0.98%)` | `19.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `85.91% <0.00%> (+1.40%)` | `21.00% <0.00%> (+1.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.49% <0.00%> (+1.68%)` | `6.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <0.00%> (+2.56%)` | `9.00% <0.00%> (+1.00%)` | |
| [.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==) | `55.88% <0.00%> (+2.94%)` | `7.00% <0.00%> (ø%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `11.39%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
=============================================
- Coverage 46.92% 35.53% -11.40%
+ Complexity 3438 2150 -1288
=============================================
Files 976 808 -168
Lines 24159 19958 -4201
Branches 2378 1895 -483
=============================================
- Hits 11337 7092 -4245
- Misses 11870 12330 +460
+ Partials 952 536 -416
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `76.47% <0.00%> (-17.65%)` | `5.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.69%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 53.61% +6.69%
- Complexity 3438 3984 +546
============================================
Files 976 1767 +791
Lines 24159 37669 +13510
Branches 2378 4177 +1799
============================================
+ Hits 11337 20197 +8860
- Misses 11870 16475 +4605
- Partials 952 997 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `100.00% <100.00%> (+5.88%)` | `6.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `30.23% <0.00%> (-62.63%)` | `3.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `17.85% <0.00%> (-37.70%)` | `2.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7InsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdJbnNlcnRSZXF1ZXN0LmphdmE=) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `60.00% <0.00%> (-15.00%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...server/core/analysis/worker/AlarmNotifyWorker.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL0FsYXJtTm90aWZ5V29ya2VyLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `3.00% <0.00%> (ø%)` | |
| ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `4.24%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 51.17% +4.24%
- Complexity 3438 3662 +224
============================================
Files 976 977 +1
Lines 24159 24209 +50
Branches 2378 2366 -12
============================================
+ Hits 11337 12388 +1051
+ Misses 11870 10775 -1095
- Partials 952 1046 +94
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/event/listener/EventRecordAnalyzerListener.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L2xpc3RlbmVyL0V2ZW50UmVjb3JkQW5hbHl6ZXJMaXN0ZW5lci5qYXZh) | `18.51% <0.00%> (-62.97%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.63% <0.00%> (-56.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [102 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `4.22%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 51.15% +4.22%
- Complexity 3438 3662 +224
============================================
Files 976 977 +1
Lines 24159 24220 +61
Branches 2378 2383 +5
============================================
+ Hits 11337 12390 +1053
+ Misses 11870 10786 -1084
- Partials 952 1044 +92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/event/listener/EventRecordAnalyzerListener.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L2xpc3RlbmVyL0V2ZW50UmVjb3JkQW5hbHl6ZXJMaXN0ZW5lci5qYXZh) | `18.51% <0.00%> (-62.97%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.63% <0.00%> (-56.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [96 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `0.74%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 47.67% +0.74%
+ Complexity 3438 2844 -594
============================================
Files 976 826 -150
Lines 24159 20616 -3543
Branches 2378 1979 -399
============================================
- Hits 11337 9829 -1508
+ Misses 11870 10008 -1862
+ Partials 952 779 -173
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| ... and [265 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777241804
@hanahmily Seems so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `2.89%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 49.82% +2.89%
- Complexity 3438 3600 +162
============================================
Files 976 976
Lines 24159 24188 +29
Branches 2378 2381 +3
============================================
+ Hits 11337 12051 +714
+ Misses 11870 11082 -788
- Partials 952 1055 +103
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| ... and [107 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `3.39%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 50.32% +3.39%
- Complexity 3438 3607 +169
============================================
Files 976 977 +1
Lines 24159 24209 +50
Branches 2378 2366 -12
============================================
+ Hits 11337 12183 +846
+ Misses 11870 10990 -880
- Partials 952 1036 +84
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-95.46%)` | `0.00% <0.00%> (-17.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/event/listener/EventRecordAnalyzerListener.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L2xpc3RlbmVyL0V2ZW50UmVjb3JkQW5hbHl6ZXJMaXN0ZW5lci5qYXZh) | `18.51% <0.00%> (-62.97%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [107 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `5.83%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 41.09% -5.84%
+ Complexity 3438 3001 -437
============================================
Files 976 959 -17
Lines 24159 23597 -562
Branches 2378 2304 -74
============================================
- Hits 11337 9697 -1640
- Misses 11870 13053 +1183
+ Partials 952 847 -105
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `82.35% <0.00%> (-11.77%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `4.94%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 51.86% +4.94%
- Complexity 3438 3676 +238
============================================
Files 976 977 +1
Lines 24159 24203 +44
Branches 2378 2363 -15
============================================
+ Hits 11337 12554 +1217
+ Misses 11870 10538 -1332
- Partials 952 1111 +159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.35%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 53.27% +6.35%
- Complexity 3438 3736 +298
============================================
Files 976 977 +1
Lines 24159 24216 +57
Branches 2378 2363 -15
============================================
+ Hits 11337 12902 +1565
+ Misses 11870 10157 -1713
- Partials 952 1157 +205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [172 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `11.34%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
=============================================
- Coverage 46.92% 35.57% -11.35%
+ Complexity 3438 2155 -1283
=============================================
Files 976 808 -168
Lines 24159 19958 -4201
Branches 2378 1895 -483
=============================================
- Hits 11337 7101 -4236
- Misses 11870 12325 +455
+ Partials 952 532 -420
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `76.47% <0.00%> (-17.65%)` | `5.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `4.22%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 51.15% +4.22%
- Complexity 3438 3662 +224
============================================
Files 976 977 +1
Lines 24159 24220 +61
Branches 2378 2383 +5
============================================
+ Hits 11337 12389 +1052
+ Misses 11870 10786 -1084
- Partials 952 1045 +93
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/event/listener/EventRecordAnalyzerListener.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L2xpc3RlbmVyL0V2ZW50UmVjb3JkQW5hbHl6ZXJMaXN0ZW5lci5qYXZh) | `18.51% <0.00%> (-62.97%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.63% <0.00%> (-56.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `9.67%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 56.60% +9.67%
- Complexity 3438 3957 +519
============================================
Files 976 977 +1
Lines 24159 24282 +123
Branches 2378 2386 +8
============================================
+ Hits 11337 13745 +2408
+ Misses 11870 9328 -2542
- Partials 952 1209 +257
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `45.45% <0.00%> (-14.55%)` | `3.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==) | `48.88% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `54.26% <0.00%> (+0.89%)` | `12.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.39% <0.00%> (+0.98%)` | `19.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `85.91% <0.00%> (+1.40%)` | `21.00% <0.00%> (+1.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.49% <0.00%> (+1.68%)` | `6.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <0.00%> (+2.56%)` | `9.00% <0.00%> (+1.00%)` | |
| ... and [141 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.38%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 53.31% +6.38%
- Complexity 3438 3737 +299
============================================
Files 976 977 +1
Lines 24159 24216 +57
Branches 2378 2363 -15
============================================
+ Hits 11337 12910 +1573
+ Misses 11870 10149 -1721
- Partials 952 1157 +205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [171 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `5.87%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 41.04% -5.88%
+ Complexity 3438 2998 -440
============================================
Files 976 959 -17
Lines 24159 23597 -562
Branches 2378 2304 -74
============================================
- Hits 11337 9686 -1651
- Misses 11870 13064 +1194
+ Partials 952 847 -105
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `82.35% <0.00%> (-11.77%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `5.70%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 41.21% -5.71%
+ Complexity 3438 3018 -420
============================================
Files 976 959 -17
Lines 24159 23606 -553
Branches 2378 2304 -74
============================================
- Hits 11337 9730 -1607
- Misses 11870 13031 +1161
+ Partials 952 845 -107
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `82.35% <0.00%> (-11.77%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `6.23%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 40.69% -6.24%
+ Complexity 3438 2397 -1041
============================================
Files 976 808 -168
Lines 24159 19903 -4256
Branches 2378 1873 -505
============================================
- Hits 11337 8099 -3238
+ Misses 11870 11173 -697
+ Partials 952 631 -321
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <50.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [350 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `13.42%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
=============================================
- Coverage 46.92% 33.50% -13.43%
+ Complexity 3438 1999 -1439
=============================================
Files 976 808 -168
Lines 24159 19851 -4308
Branches 2378 1868 -510
=============================================
- Hits 11337 6651 -4686
- Misses 11870 12721 +851
+ Partials 952 479 -473
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <50.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [363 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `9.43%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 56.35% +9.43%
- Complexity 3438 3951 +513
============================================
Files 976 977 +1
Lines 24159 24282 +123
Branches 2378 2386 +8
============================================
+ Hits 11337 13685 +2348
+ Misses 11870 9405 -2465
- Partials 952 1192 +240
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.63% <0.00%> (-56.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyRXZlbnRRdWVyeURBTy5qYXZh) | `1.58% <0.00%> (-46.04%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==) | `48.88% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `54.26% <0.00%> (+0.89%)` | `12.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.39% <0.00%> (+0.98%)` | `19.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `85.91% <0.00%> (+1.40%)` | `21.00% <0.00%> (+1.00%)` | |
| ... and [143 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `9.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 37.92% -9.01%
+ Complexity 3438 2251 -1187
============================================
Files 976 808 -168
Lines 24159 19869 -4290
Branches 2378 1869 -509
============================================
- Hits 11337 7535 -3802
+ Misses 11870 11745 -125
+ Partials 952 589 -363
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <50.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [375 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `9.34%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 56.26% +9.34%
- Complexity 3438 3945 +507
============================================
Files 976 977 +1
Lines 24159 24282 +123
Branches 2378 2386 +8
============================================
+ Hits 11337 13663 +2326
+ Misses 11870 9427 -2443
- Partials 952 1192 +240
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.63% <0.00%> (-56.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyRXZlbnRRdWVyeURBTy5qYXZh) | `1.58% <0.00%> (-46.04%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==) | `48.88% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `54.26% <0.00%> (+0.89%)` | `12.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.39% <0.00%> (+0.98%)` | `19.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `85.91% <0.00%> (+1.40%)` | `21.00% <0.00%> (+1.00%)` | |
| ... and [141 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `0.50%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 46.42% -0.51%
+ Complexity 3438 2789 -649
============================================
Files 976 826 -150
Lines 24159 20588 -3571
Branches 2378 1974 -404
============================================
- Hits 11337 9558 -1779
+ Misses 11870 10286 -1584
+ Partials 952 744 -208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [267 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `4.23%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 51.16% +4.23%
- Complexity 3438 3662 +224
============================================
Files 976 977 +1
Lines 24159 24212 +53
Branches 2378 2368 -10
============================================
+ Hits 11337 12388 +1051
+ Misses 11870 10778 -1092
- Partials 952 1046 +94
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/event/listener/EventRecordAnalyzerListener.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L2xpc3RlbmVyL0V2ZW50UmVjb3JkQW5hbHl6ZXJMaXN0ZW5lci5qYXZh) | `18.51% <0.00%> (-62.97%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.63% <0.00%> (-56.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `2.70%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 49.63% +2.70%
- Complexity 3438 3564 +126
============================================
Files 976 977 +1
Lines 24159 24209 +50
Branches 2378 2366 -12
============================================
+ Hits 11337 12015 +678
+ Misses 11870 11173 -697
- Partials 952 1021 +69
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <0.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-95.46%)` | `0.00% <0.00%> (-17.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `4.40%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 51.32% +4.40%
- Complexity 3438 3666 +228
============================================
Files 976 976
Lines 24159 24188 +29
Branches 2378 2381 +3
============================================
+ Hits 11337 12415 +1078
+ Misses 11870 10682 -1188
- Partials 952 1091 +139
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| ... and [120 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `6.05%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 52.98% +6.05%
- Complexity 3438 3727 +289
============================================
Files 976 977 +1
Lines 24159 24216 +57
Branches 2378 2363 -15
============================================
+ Hits 11337 12831 +1494
+ Misses 11870 10245 -1625
- Partials 952 1140 +188
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `0.51%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 47.44% +0.51%
+ Complexity 3438 3371 -67
============================================
Files 976 959 -17
Lines 24159 23673 -486
Branches 2378 2309 -69
============================================
- Hits 11337 11231 -106
+ Misses 11870 11477 -393
- Partials 952 965 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <0.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [160 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `0.17%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 46.75% -0.18%
+ Complexity 3438 3332 -106
============================================
Files 976 959 -17
Lines 24159 23670 -489
Branches 2378 2309 -69
============================================
- Hits 11337 11067 -270
+ Misses 11870 11640 -230
- Partials 952 963 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <0.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (7d5f22b) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `5.70%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 52.63% +5.70%
- Complexity 3438 3706 +268
============================================
Files 976 977 +1
Lines 24159 24203 +44
Branches 2378 2363 -15
============================================
+ Hits 11337 12739 +1402
+ Misses 11870 10336 -1534
- Partials 952 1128 +176
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `0.17%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 46.75% -0.18%
+ Complexity 3438 3332 -106
============================================
Files 976 959 -17
Lines 24159 23670 -489
Branches 2378 2309 -69
============================================
- Hits 11337 11067 -270
+ Misses 11870 11640 -230
- Partials 952 963 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <0.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `10.34%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
=============================================
+ Coverage 46.92% 57.27% +10.34%
- Complexity 3438 3983 +545
=============================================
Files 976 977 +1
Lines 24159 24282 +123
Branches 2378 2386 +8
=============================================
+ Hits 11337 13907 +2570
+ Misses 11870 9159 -2711
- Partials 952 1216 +264
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==) | `48.88% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `54.26% <0.00%> (+0.89%)` | `12.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.39% <0.00%> (+0.98%)` | `19.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `85.91% <0.00%> (+1.40%)` | `21.00% <0.00%> (+1.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.49% <0.00%> (+1.68%)` | `6.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <0.00%> (+2.56%)` | `9.00% <0.00%> (+1.00%)` | |
| [.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==) | `55.88% <0.00%> (+2.94%)` | `7.00% <0.00%> (ø%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `2.37%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 44.55% -2.38%
+ Complexity 3438 2704 -734
============================================
Files 976 826 -150
Lines 24159 20563 -3596
Branches 2378 1958 -420
============================================
- Hits 11337 9161 -2176
+ Misses 11870 10669 -1201
+ Partials 952 733 -219
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `88.23% <0.00%> (-5.89%)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [287 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (bd768ac) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **increase** coverage by `2.88%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
+ Coverage 46.92% 49.81% +2.88%
- Complexity 3438 3599 +161
============================================
Files 976 976
Lines 24159 24188 +29
Branches 2378 2381 +3
============================================
+ Hits 11337 12049 +712
+ Misses 11870 11083 -787
- Partials 952 1056 +104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `94.11% <50.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| ... and [108 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...6a7802b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6363: Change the Apdex metric combine calculator
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6363:
URL: https://github.com/apache/skywalking/pull/6363#issuecomment-777220776
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=h1) Report
> Merging [#6363](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=desc) (6c1eb58) into [master](https://codecov.io/gh/apache/skywalking/commit/92d0465cd839e22f859b0c9cfe7b2928d502ad2f?el=desc) (92d0465) will **decrease** coverage by `7.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6363 +/- ##
============================================
- Coverage 46.92% 39.91% -7.02%
+ Complexity 3438 2930 -508
============================================
Files 976 959 -17
Lines 24159 23575 -584
Branches 2378 2301 -77
============================================
- Hits 11337 9409 -1928
- Misses 11870 13345 +1475
+ Partials 952 821 -131
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `76.47% <0.00%> (-17.65%)` | `5.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6363/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=footer). Last update [92d0465...7d5f22b](https://codecov.io/gh/apache/skywalking/pull/6363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org