You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/06/25 19:59:36 UTC

Re: Review Request 70835: Added the DrainConfig to agent API outputs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70835/
-----------------------------------------------------------

(Updated June 25, 2019, 7:59 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.


Summary (updated)
-----------------

Added the DrainConfig to agent API outputs.


Bugs: MESOS-9818
    https://issues.apache.org/jira/browse/MESOS-9818


Repository: mesos


Description (updated)
-------

Added the DrainConfig to agent API outputs.


Diffs (updated)
-----

  include/mesos/agent/agent.proto 83eb7bbe071fe4f118c38252bd1759ac90fc9c33 
  include/mesos/v1/agent/agent.proto f6574cbb899f3ffca9f5f07f1a235c01cf97912e 
  src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 


Diff: https://reviews.apache.org/r/70835/diff/2/

Changes: https://reviews.apache.org/r/70835/diff/1-2/


Testing
-------

Testing details at the end of this chain.


Thanks,

Greg Mann


Re: Review Request 70835: Added the DrainConfig to agent API outputs.

Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70835/#review216188
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On June 25, 2019, 9:59 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70835/
> -----------------------------------------------------------
> 
> (Updated June 25, 2019, 9:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9818
>     https://issues.apache.org/jira/browse/MESOS-9818
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the DrainConfig to agent API outputs.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 83eb7bbe071fe4f118c38252bd1759ac90fc9c33 
>   include/mesos/v1/agent/agent.proto f6574cbb899f3ffca9f5f07f1a235c01cf97912e 
>   src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 
> 
> 
> Diff: https://reviews.apache.org/r/70835/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>