[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20559: fix: add kylin physical datasets.

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #20559:
URL: https://github.com/apache/superset/pull/20559#discussion_r910661315


##########
superset/models/core.py:
##########
@@ -760,11 +760,11 @@ def get_perm(self) -> str:
 
     def has_table(self, table: Table) -> bool:
         engine = self.get_sqla_engine()
-        return engine.has_table(table.table_name, table.schema or None)
+        return engine.has_table(table.table_name, table.schema or None) or table.table_name in engine.table_names()

Review Comment:
   I am the original Kylinpy maintainer, I just saw the source code of kylinpy. I think you should change [here](https://github.com/Kyligence/kylinpy/blob/04f360f9d07af8cf081e6d259893ba8a88b9376b/kylinpy/sqla_dialect.py#L124) .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org