You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/08 21:06:03 UTC

[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder

TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1208609859

   @lostluck it looks like Go might be using the same coder for single-precision floats as for double-precision, is that right? From the Go PreCommit:
   
   ```
   13:58:13 --- FAIL: TestStandardCoders (0.03s)
   13:58:13     --- FAIL: TestStandardCoders/beam:coder:row:v1#06 (0.00s)
   13:58:13         fromyaml_test.go:42: Failed "{beam:coder:row:v1 
   13:58:13             
   13:58:13             f_float$8c97b6c5-69e5-4733-907b-26cd8edae612 [] false}": err decoding "\x01\x00\x00\x00\x00\x00": decoding a struct { F_float float32 "beam:\"f_float\"" }
   13:58:13             	caused by:
   13:58:13             error decoding double field
   13:58:13             	caused by:
   13:58:13             EOF
   13:58:13 FAIL
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org