[GitHub] [solr] cpoerschke commented on a change in pull request #195: SOLR-15385 RawTypes Part IV, solr-core

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #195:
URL: https://github.com/apache/solr/pull/195#discussion_r659208737



##########
File path: solr/core/src/java/org/apache/solr/response/CSVResponseWriter.java
##########
@@ -318,29 +318,27 @@ public void close() throws IOException {
   }
 
   //NOTE: a document cannot currently contain another document
-  @SuppressWarnings({"rawtypes"})
-  List tmpList;
+  List<Object> tmpList;

Review comment:
       unrelated to the changes in this pull request: could this be private and/or have a comment w.r.t. why it's not just a local variable in `writeSolrDocument` would be helpful

##########
File path: solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java
##########
@@ -442,23 +442,23 @@ public void modifyRequest(ResponseBuilder rb, SearchComponent who, ShardRequest
 
 
   @Override
-  @SuppressWarnings({"unchecked", "rawtypes"})
   public void handleResponses(ResponseBuilder rb, ShardRequest sreq) {
 
     if (!rb.doExpand) {
       return;
     }
     if ((sreq.purpose & ShardRequest.PURPOSE_GET_FIELDS) != 0) {
       SolrQueryRequest req = rb.req;
-      NamedList expanded = (NamedList) req.getContext().get("expanded");
+      @SuppressWarnings("unchecked")
+      NamedList<Object> expanded = (NamedList<Object>) req.getContext().get("expanded");
       if (expanded == null) {
-        expanded = new SimpleOrderedMap();
+        expanded = new SimpleOrderedMap<>();
         req.getContext().put("expanded", expanded);
       }
 
       for (ShardResponse srsp : sreq.responses) {
-        NamedList response = srsp.getSolrResponse().getResponse();
-        NamedList ex = (NamedList) response.get("expanded");
+        NamedList<Object> response = srsp.getSolrResponse().getResponse();
+        NamedList<?> ex = (NamedList<?>) response.get("expanded");

Review comment:
       `NamedList<?>` here but `NamedList<Object>` above, both for `expanded`, is unexpected at a glance, not yet looked into possible reasons for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org