You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/24 16:20:07 UTC
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #6812: [C++] Fix message id is always the default value in send callback
BewareMyPower commented on a change in pull request #6812:
URL: https://github.com/apache/pulsar/pull/6812#discussion_r414700129
##########
File path: pulsar-client-cpp/tests/BatchMessageTest.cc
##########
@@ -982,4 +982,48 @@ TEST(BatchMessageTest, testPraseMessageBatchEntry) {
ASSERT_EQ(message.getDataAsString(), expected.content);
ASSERT_EQ(message.getProperty(expected.propKey), expected.propValue);
}
-}
\ No newline at end of file
+}
+
+TEST(BatchMessageTest, testSendCallback) {
+ const std::string topicName = "persistent://public/default/BasicMessageTest-testSendCallback";
+
+ Client client(lookupUrl);
+
+ constexpr int numMessagesOfBatch = 3;
+
+ ProducerConfiguration producerConfig;
+ producerConfig.setBatchingEnabled(5);
+ producerConfig.setBatchingMaxMessages(numMessagesOfBatch);
+ producerConfig.setBatchingMaxPublishDelayMs(1000); // 1 s, it's long enough for 3 messages batched
+ producerConfig.setMaxPendingMessages(numMessagesOfBatch);
+
+ Producer producer;
+ ASSERT_EQ(ResultOk, client.createProducer(topicName, producerConfig, producer));
+
+ Consumer consumer;
+ ASSERT_EQ(ResultOk, client.subscribe(topicName, "SubscriptionName", consumer));
+
+ std::set<MessageId> sentIdSet;
+ for (int i = 0; i < numMessagesOfBatch; i++) {
+ const auto msg = MessageBuilder().setContent("a").build();
+ producer.sendAsync(msg, [&sentIdSet, i](Result result, const MessageId& id) {
+ ASSERT_EQ(ResultOk, result);
+ ASSERT_EQ(i, id.batchIndex());
+ sentIdSet.emplace(id);
Review comment:
Thank you for pointing out this! I missed the point that the `SendReceipt` to producer is not guaranteed to be completed before the consumer's `receive()` done. I'll do some work on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org