You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/18 12:56:05 UTC

[GitHub] [spark] zhaorongsheng commented on a change in pull request #24118: [SPARK-26736][SQL] if filter condition has rand() function it does not do partition prunning

zhaorongsheng commented on a change in pull request #24118: [SPARK-26736][SQL] if filter condition has rand() function it does not do partition prunning
URL: https://github.com/apache/spark/pull/24118#discussion_r266424938
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
 ##########
 @@ -63,7 +63,7 @@ object PhysicalOperation extends PredicateHelper {
         val substitutedFields = fields.map(substitute(aliases)).asInstanceOf[Seq[NamedExpression]]
         (Some(substitutedFields), filters, other, collectAliases(substitutedFields))
 
-      case Filter(condition, child) if condition.deterministic =>
+      case Filter(condition, child) if condition.deterministic || condition.isInstanceOf[And] =>
 
 Review comment:
   It has been updated. Please review it, thanks~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org