You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/21 15:36:39 UTC

[kudu-CR] [backup] Fix backup tools packaging

Hello Will Berkeley, Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13691

to look at the new patch set (#2).

Change subject: [backup] Fix backup tools packaging
......................................................................

[backup] Fix backup tools packaging

This patch adjusts how we package the kudu-backup-tools
module. Instead of building a fat jar that contains all of
the hadoop classes, the hadoop classes are now marked
as provided and therfore not included.

This change was made with two concerns in mind.
Primarily because the defacto way to load the
environments hadoop configuration is from the
classpath via `hadoop classpath`. A secondary benefit
is that loading the classpath this way avoids any
potential hadoop compatibility issues.

An example execution of the jar would now be:
`java -cp $(hadoop classpath):kudu-backup-tools-1.10.0.jar org.apache.kudu.backup.KuduBackupCLI`

Additionally this patch adds integration tests for the
`hdfs` uri in the tests using a hadoop-minicluster.

Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
---
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
7 files changed, 100 insertions(+), 81 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/13691/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
Gerrit-Change-Number: 13691
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>